compute: columnar Constant output - #37766
Draft
antiguru wants to merge 2 commits into
Draft
Conversation
antiguru
force-pushed
the
columnar-p2-constant
branch
from
July 22, 2026 08:41
a81e15e to
21f51b2
Compare
antiguru
force-pushed
the
columnar-p2-constant
branch
from
July 22, 2026 16:25
21f51b2 to
6f5df11
Compare
antiguru
changed the title
antiguru
force-pushed
the
columnar-p2-constant
branch
from
July 22, 2026 17:51
6f5df11 to
3aa6002
Compare
antiguru
force-pushed
the
columnar-p2-constant
branch
from
August 19, 2026 12:01
3aa6002 to
b04d92f
Compare
antiguru
force-pushed
the
columnar-p2-constant
branch
from
August 19, 2026 13:17
b04d92f to
cfadadb
Compare
antiguru
force-pushed
the
columnar-p2-constant
branch
2 times, most recently
from
August 20, 2026 09:13
104761d to
708eb84
Compare
Build the `Constant` arm of `render_plan_expr` into a `Column` and return a `CollectionEdge::Columnar`, flipping the constant literal source to emit the columnar edge. The err collection stays row-based (out of scope). The rows go through a `ConsolidatingColumnBuilder` via `to_stream_with_builder` rather than a direct columnar build. The planner (`FoldConstants`) consolidates constant rows by `(row, time)` at optimization time, but this arm then advances every time to `as_of`, which can collapse distinct original times onto one time and so reintroduce duplicates at the same `(row, time)`. Consolidating here folds those within the batch, matching the standing producer rule. The constant rows are already owned, so the give is a move into staging, not a new allocation. The `as_of` advancement and `until` filtering are unchanged. Test: extends degenerate.slt with a constant carrying duplicate rows (asserting multiplicity survives the columnar edge) and a constant feeding an indexed view and an aggregate, exercising the columnar producer against ArrangeBy and Reduce consumers. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The comment named the migration plan's node for this conversion, which means nothing to a reader of the test.
antiguru
force-pushed
the
columnar-p2-constant
branch
from
September 6, 2026 18:23
708eb84 to
c0fe9e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Constant collections emit their output as the columnar edge.
Columnar dataflow-edge migration. Design doc:
doc/developer/design/20260720_columnar_dataflow_edges.md(#37744).Part of CPU-51.