compute: Re-encode temporal-bucketing output as the columnar edge - #37787
Draft
antiguru wants to merge 3 commits into
Draft
compute: Re-encode temporal-bucketing output as the columnar edge#37787antiguru wants to merge 3 commits into
antiguru wants to merge 3 commits into
Conversation
antiguru
force-pushed
the
columnar-ta-temporal-bucket-reencode
branch
from
July 22, 2026 08:41
9978083 to
038ee6e
Compare
antiguru
force-pushed
the
columnar-ta-temporal-bucket-reencode
branch
from
July 22, 2026 16:24
038ee6e to
d5f9095
Compare
antiguru
force-pushed
the
columnar-ta-temporal-bucket-reencode
branch
from
July 22, 2026 17:51
d5f9095 to
49c35f9
Compare
antiguru
force-pushed
the
columnar-ta-temporal-bucket-reencode
branch
2 times, most recently
from
August 19, 2026 13:17
fd0f181 to
aab0e0d
Compare
antiguru
force-pushed
the
columnar-ta-temporal-bucket-reencode
branch
from
August 20, 2026 08:49
aab0e0d to
8769666
Compare
antiguru
force-pushed
the
columnar-ta-temporal-bucket-reencode
branch
from
August 20, 2026 09:13
8769666 to
13ee1e0
Compare
Temporal bucketing (`maybe_apply_temporal_bucketing`) is `Vec`-internal: it consumes and produces a `StreamVec`. The four sites that drive it previously decoded the edge with `into_vec` and then re-wrapped the `Vec` result as `CollectionEdge::Vec`, leaving the last `Vec` producer that fed a Union's `concat_many`. Re-encode each bucketed result with `vec_to_columnar` so the output edge is columnar, matching every other producer after the producer wave. The bucketer stays on `Vec` internally; only its output boundary changes. This is a non-consolidating leaf encode, since the bucketer output is not consolidated and the prior `CollectionEdge::Vec` wrap was non-consolidating. With every producer now columnar, a consolidating Union that mixes a bucketed input with a `Direct` input feeds `concat_many` two columnar edges instead of a mixed pair. Adds runtime coverage to `temporal_bucketing.slt` under `enable_compute_temporal_bucketing`: bucketed Reduce, bucketed TopK, and an `EXCEPT ALL` whose Union carries `[TemporalBucketing, Direct]`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Comment-only, no behavior change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The comments named the migration plan's nodes, which mean nothing to a reader, and described the union input in terms of a mixed-variant `concat_many` case rather than what the code does.
antiguru
force-pushed
the
columnar-ta-temporal-bucket-reencode
branch
from
September 6, 2026 18:23
13ee1e0 to
1bfb45e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-encode the temporal-bucketing output back to the columnar edge; the operator itself still works over
Vecinternally. Removes one mixed-variant edge source ahead of theconcat_manyteardown.Columnar dataflow-edge migration. Design doc:
doc/developer/design/20260720_columnar_dataflow_edges.md(#37744).Part of CPU-51.