Migrate DHE test cases to ECDHE #9916
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valeriosetti
added
needs-review
… alternative Tests removed here already have an ECDHE-RSA alternative in test_suite_ssl.data, so they can be removed. Signed-off-by: Valerio Setti <[email protected]>
Use ECDHE-RSA instead of DHE-RSA. Signed-off-by: Valerio Setti <[email protected]>
These tests were specific for DHE-RSA (which is being removed on development branch) and also for each of them there was already the ECDHE-RSA counterpart available. Signed-off-by: Valerio Setti <[email protected]>
valeriosetti
force-pushed
the
issue9688
branch
from
8c93c9b to
a7ba35c
Compare
Harry-Ramsey
previously approved these changes
Jan 22, 2025
There was a problem hiding this comment.
LGTM
I did notice however that these lines in test_suite_ssl.data are present althought I am not sure if they should be removed.
Test configuration of groups for DHE through mbedtls_ssl_conf_curves()
conf_curve:
Test configuration of groups for DHE through mbedtls_ssl_conf_groups()
conf_group:
Oh, good catch! IMO those tests seems to be DHE specific, so they can just be removed. I'll update the commits. |
Signed-off-by: Valerio Setti <[email protected]>
Adapted tests do not already have an ECDHE-RSA test available. Signed-off-by: Valerio Setti <[email protected]>
For these ones there is no ECDHE alternative as they are testing specific features of DHE. Signed-off-by: Valerio Setti <[email protected]>
Remove tests which are forcing DHE-RSA, but for which an ECDHE-RSA alternative already exists. Signed-off-by: Valerio Setti <[email protected]>
valeriosetti
force-pushed
the
issue9688
branch
from
a7ba35c to
4c1a996
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resoves #9688
PR checklist