[Ricky Wong (mo-rickywong)]

PR Summary

Sci/Tech Reviewer: Thomas Bendall (@tommbendall)
Code Reviewer: Steve Mullerworth (@stevemullerworth)

Update Apps repository as impacted by changes in lfric_core PR MetOffice/lfric_core#440. This is a result of changes to the api of kernels in an initial tranche of updates in lfric_core.

This PR updates applications in LFRic apps by:

• Passing of config_type to algorithms that call affected kernels.

• Extraction of the required namelist variables to be passed by argument.

• Where applicable, passing of mesh_id is replaced with passing the mesh object itself, with config, mesh arguments at the beginning of argument lists.

• Note: geology/topology is not extracted from base_mesh_config, it is queried from the mesh object. base_mesh was only intended for use by top-level application driver code, the intention is to phase out parts of base_mesh and delegate that functionality to individual applications. (see blocking PRS)

Linked PRs

• linked Remove global scope access of namelist configurations from science component kernels with feigners (tranche 1) lfric_core#440

This PR is blocked

• blocked-by Changes to apps as a result of decoupling base_mesh_config geometry / topology enumerations #757

Code Quality Checklist

• I have performed a self-review of my own code
• My code follows the project's style guidelines
• Comments have been included that aid understanding and enhance the readability of the code
• My changes generate no new warnings
• All automated checks in the CI pipeline have completed successfully

Testing

• I have tested this change locally, using the LFRic Apps rose-stem suite
• If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
• I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
• Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_apps - AppsCleanFeigners_1/run1

Suite Information

Item	Value
Suite Name	AppsCleanFeigners_1/run1
Suite User	ricky.wong
Workflow Start	2026-09-03T14:35:42
Groups Run	developer

Dependency	Reference	Main Like
casim	MetOffice/casim@2026.07.1	True
jules	MetOffice/jules@2026.07.1	True
lfric_apps	mo-rickywong/lfric_apps@AppsCleanFeigners_1	False
lfric_core	mo-rickywong/lfric_core@ClearFeigners_1	True
moci	MetOffice/moci@2026.07.1	True
SimSys_Scripts	MetOffice/SimSys_Scripts@77a5166	True
socrates	MetOffice/socrates@2026.07.1	True
socrates-spectral	MetOffice/socrates-spectral@2026.07.1	True
ukca	MetOffice/ukca@9fc2b6d	True

Task Information

✅ succeeded tasks - 1218

Security Considerations

• I have reviewed my changes for potential security issues
• Sensitive data is properly handled (if applicable)
• Authentication and authorisation are properly implemented (if applicable)

Performance Impact

• Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

• Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

• Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

• If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

• I understand this area of code and the changes being added
• The proposed changes correspond to the pull request description
• Documentation is sufficient (do documentation papers need updating)
• Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

• All dependencies have been resolved
• Related Issues have been properly linked and addressed
• CLA compliance has been confirmed
• Code quality standards have been met
• Tests are adequate and have passed
• Documentation is complete and accurate
• Security considerations have been addressed
• Performance impact is acceptable

[DanStoneMO]

Tested JEDI with this and it ran fine, no linked PR needed for it

[thomasmelvin]

Looks good to me, one trivial comment for consideration

[Thomas Bendall (tommbendall)]

I used this diff to check changes to the predecessor PR: mo-rickywong/lfric_apps@AppsDecoupleGeoTop...mo-rickywong:lfric_apps:AppsCleanFeigners_1

The Apps changes explain my question on the linked Core PR about why config is passed as an argument to the solver apply method.

Happy to approve

[Thomas Bendall (tommbendall)]

I've marked this as passing science review so is ready for code review Steve Mullerworth (@stevemullerworth)

[DrTVockerodtMO]

Changes look fine, I've suggested some small style fixes.

[DrTVockerodtMO]

Suggested change

	type(config_type), intent(in) :: config
	type(config_type), intent(in) :: config

[DrTVockerodtMO]

This can be reverted.

Suggested change

	call atl_end_conservative_step_alg( field_np1, field_in, &
	call atl_end_conservative_step_alg( field_np1, field_in, &

[Ricky Wong (mo-rickywong)]

Blocking branches are now on trunk. This branch has been moved to head of trunk and tested with its linked CorePR. It is now ready for Code Review