Skip to content

Conversation

@ccharly
Copy link
Contributor

@ccharly ccharly commented Dec 5, 2025

Explanation

Moving the add/remove account/address logic in the KeyringController. This way, we don't need to run a complex logic in the AccountsController everytime a new account gets added.

Part of this logic is now at the KeyringController-level yes, but the logic itself seems simpler, and hopefully, is faster too!

References

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

@ccharly ccharly force-pushed the feat/keyring-controller-account-added branch from f128679 to e8ec6c8 Compare December 5, 2025 19:01
@ccharly ccharly force-pushed the feat/keyring-controller-account-added branch from e8ec6c8 to 3fe4986 Compare December 8, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants