Skip to content

feat: add KeyringController:accountAdded event + use keyring events in AccountsController #7328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ccharly wants to merge 16 commits into
base: main
Choose a base branch
from
+552 −735
Open

feat: add KeyringController:accountAdded event + use keyring events in AccountsController #7328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
3fe4986
feat: add KeyringController:accountAdded event + use keyring events i…
ccharly Dec 5, 2025
b4700b2
fix: add missing return types
ccharly Dec 8, 2025
537e318
refactor: more DRY
ccharly Dec 8, 2025
e137a0b
fix: revert change to :accountRemoved
ccharly Dec 8, 2025
1a2a27c
refactor: keyringEventInfo -> keyringObject
ccharly Dec 8, 2025
e6eaaa1
test: add new tests
ccharly Dec 8, 2025
98c92c6
Merge branch 'main' into feat/keyring-controller-account-added
ccharly Dec 12, 2025
fe85881
test: add more test for persistAllKeyrings + lint
ccharly Dec 12, 2025
cab3f12
refactor: re-adapt accounts-controller tests
ccharly Dec 12, 2025
fda91cd
fix: fix accounts-controller new event handling
ccharly Dec 12, 2025
f7f52ce
chore: lint
ccharly Dec 12, 2025
5fee36e
chore: changelogs
ccharly Dec 12, 2025
54d6e16
refactor: override update to cover all possible use-cases
ccharly Dec 12, 2025
a5c5f5d
Merge branch 'main' into feat/keyring-controller-account-added
ccharly Dec 12, 2025
81198db
chore: add missing jsdocs
ccharly Dec 12, 2025
5009b0a
fix: remove extra :accountRemoved
ccharly Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/accounts-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- **BREAKING:** Use new `KeyringController:account{Added,Removed}` events instead of the `KeyringController:stateChange` ([#7328](https://github.com/MetaMask/core/pull/7328))
- This simplify the re-synchronization between keyrings and this controller.
- This should also improve performance slightly.
- Move peer dependencies for controller and service packages to direct dependencies ([#7209](https://github.com/MetaMask/core/pull/7209), [#7258](https://github.com/MetaMask/core/pull/7258))
- The dependencies moved are:
- `@metamask/keyring-controller` (^25.0.0)
Expand Down
Loading
Loading