Yarnv3 upgrade #129
Open
Yarnv3 upgrade #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5906de6.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| timeout_minutes: 15 | ||
| max_attempts: 3 | ||
| retry_wait_seconds: 30 | ||
| command: yarn detox --version |
There was a problem hiding this comment.
Bug: Detox CLI Missing in Yarn v2 Action
The 'Verify Detox CLI' step runs yarn detox --version but detox-cli is never installed, unlike in the Yarn v1 action. This causes the verification to fail, preventing E2E test setup.
| required: true | ||
| secret-name: | ||
| description: 'The name of the secret in AWS Secrets Manager' | ||
| required: true |
There was a problem hiding this comment.
Bug: Unused Required Parameter Causes Confusion
The secret-name input is required but unused. The action instead derives the secret name from the target input, which can cause confusion for users providing an ignored parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.