Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
96 commits
Select commit Hold shift + click to select a range
a75fa8b
e2e-env-action
jake-perkins Jul 9, 2025
ab67bec
add more deps
jake-perkins Jul 9, 2025
22a7b88
fix cursor bug
jake-perkins Jul 9, 2025
610d928
new action shas
jake-perkins Jul 10, 2025
6ebb0f3
yarn install
jake-perkins Jul 10, 2025
f6e583d
yarn cache
jake-perkins Jul 10, 2025
e4322a4
cache act
jake-perkins Jul 10, 2025
4a81330
fix sim device
jake-perkins Jul 10, 2025
bc2f52f
bundler-cache
jake-perkins Jul 10, 2025
27eed96
try yarn.lock perf fix
jake-perkins Jul 11, 2025
c9e4d1e
cocoapods caching
jake-perkins Jul 11, 2025
f5c4f53
android tuning
jake-perkins Jul 11, 2025
860c7d4
tuning
jake-perkins Jul 11, 2025
4898cab
license-accepts
jake-perkins Jul 11, 2025
8b76ea8
foundry agnostic
jake-perkins Jul 11, 2025
f1008f7
setup
jake-perkins Jul 11, 2025
9884d8a
foundry ubuntu-mac-agnostic
jake-perkins Jul 11, 2025
682cafb
act
jake-perkins Jul 11, 2025
6a1ff90
foundry
jake-perkins Jul 11, 2025
38bd065
foundry android
jake-perkins Jul 11, 2025
2f5e2a6
remover chmod
jake-perkins Jul 11, 2025
a3ea5d4
act
jake-perkins Jul 11, 2025
8f3fdcb
act
jake-perkins Jul 11, 2025
c7d9987
act
jake-perkins Jul 11, 2025
90d1bd2
foundry
jake-perkins Jul 11, 2025
bfd20d8
act
jake-perkins Jul 11, 2025
6d49bac
cfgs
jake-perkins Jul 11, 2025
b2e0ef3
ndk setup
jake-perkins Jul 11, 2025
c35dbc6
ndk
jake-perkins Jul 11, 2025
9e75e06
ndk
jake-perkins Jul 11, 2025
dda3178
act
jake-perkins Jul 11, 2025
03cd24b
licenses
jake-perkins Jul 11, 2025
4b4e46f
android tools
jake-perkins Jul 11, 2025
02ff9a9
e2e
jake-perkins Jul 11, 2025
5695370
act
jake-perkins Jul 11, 2025
f399c35
act
jake-perkins Jul 11, 2025
4d87552
upgrade default xcode-version
jake-perkins Jul 11, 2025
929ddaa
e2e
jake-perkins Jul 11, 2025
d9de05d
lint
jake-perkins Jul 11, 2025
18421e8
android-simulator
jake-perkins Jul 11, 2025
93cf96a
android-act
jake-perkins Jul 11, 2025
db78229
fix emu bug
jake-perkins Jul 11, 2025
37051d0
act
jake-perkins Jul 11, 2025
dade476
act
jake-perkins Jul 11, 2025
8529256
emulator bugs
jake-perkins Jul 11, 2025
3b49d84
android-sim
jake-perkins Jul 11, 2025
a4ca242
act
jake-perkins Jul 11, 2025
b1867a9
act
jake-perkins Jul 11, 2025
860e85f
env
jake-perkins Jul 11, 2025
032380e
update android default abi
jake-perkins Jul 11, 2025
eea10a6
act
jake-perkins Jul 11, 2025
1366275
linting
jake-perkins Jul 12, 2025
1a08796
Merge branch 'main' into e2e-env-actions
jake-perkins Jul 12, 2025
367c013
always lay out simulator cfgs
jake-perkins Jul 15, 2025
d7a349b
E2e ubuntu runners (#87)
makemesteaks Jul 16, 2025
4459e30
E2e env actions keystore (#90)
jake-perkins Jul 18, 2025
4ee8ff1
keystore-integrations
jake-perkins Jul 18, 2025
9e04cea
keystores
jake-perkins Jul 18, 2025
aa884d6
keystore
jake-perkins Jul 18, 2025
a4d8ac3
manage node version
jake-perkins Jul 18, 2025
a3cd1cb
Emulator configs (#88)
makemesteaks Jul 18, 2025
b748908
remove cocoapods caching
jake-perkins Jul 18, 2025
8553525
fmt
jake-perkins Jul 18, 2025
8f5b198
self hosted
makemesteaks Jul 29, 2025
a1f7d18
test
makemesteaks Jul 29, 2025
2ead7cb
fail fast
makemesteaks Jul 29, 2025
5b810c9
remove ndk because its already in the runner
makemesteaks Jul 29, 2025
060107e
targets
jake-perkins Aug 4, 2025
d378d7d
fix-act
jake-perkins Aug 5, 2025
b3b5adf
slimmer pipeline
makemesteaks Jul 30, 2025
ef89e45
avd changes
makemesteaks Aug 7, 2025
c35da38
add pod vendor to path
jake-perkins Aug 28, 2025
5a428da
ruby/gem troubleshooting
jake-perkins Aug 28, 2025
4364187
pod verify
jake-perkins Aug 28, 2025
93a7c6e
binstub
jake-perkins Aug 28, 2025
1c024c7
binstub
jake-perkins Aug 28, 2025
9a1f3b3
binstub
jake-perkins Aug 29, 2025
b622c5f
configs
jake-perkins Aug 29, 2025
c526726
supress partition list output
jake-perkins Aug 29, 2025
3447281
ci
jake-perkins Sep 2, 2025
a345f7c
debugging
jake-perkins Sep 2, 2025
b532e7f
keystore debugs
jake-perkins Sep 2, 2025
4f03564
configs
jake-perkins Sep 2, 2025
ed3592d
compare fingerprints
jake-perkins Sep 2, 2025
51c3ae9
default-chain
jake-perkins Sep 2, 2025
4eec245
codesignign config
jake-perkins Sep 2, 2025
e95f53d
test ssl
makemesteaks Sep 3, 2025
6ac80cb
remove debugging
jake-perkins Sep 3, 2025
394f14c
keychain
jake-perkins Sep 3, 2025
5906de6
chore: retries (#122)
makemesteaks Sep 11, 2025
fb91d27
Revert "chore: retries (#122)"
makemesteaks Sep 11, 2025
9e5ee8b
feat(INFRA-2932): add retry to yarn commands self hosted (#126)
bsgrigorov Sep 17, 2025
2f1cdf9
add action to yarn v3 of setup-e2e-env
tommasini Sep 17, 2025
197371d
shell bash added
tommasini Sep 17, 2025
1d567b7
fix setup e2e env var w yarn v3
tommasini Sep 17, 2025
f1d2c36
chore: add retry to corepack step
alucardzom Sep 18, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
148 changes: 148 additions & 0 deletions .github/actions/configure-keystore/action.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,148 @@
name: 'Configure Keystore'
description: 'Assume an AWS role and fetch a secret into environment variables'

inputs:
aws-role-to-assume:
description: 'The AWS IAM role to assume'
required: true
aws-region:
description: 'The AWS region where the secret is stored'
required: true
secret-name:
description: 'The name of the secret in AWS Secrets Manager'
required: true
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Unused Required Parameter Causes Confusion

The secret-name input is required but unused. The action instead derives the secret name from the target input, which can cause confusion for users providing an ignored parameter.

Fix in Cursor Fix in Web

platform:
description: 'The platform for which the keystore is being configured (e.g., ios, android)'
required: true
target:
description: 'The target for which the keystore is being configured (e.g., qa, flask, main)'
required: true

runs:
using: 'composite'
steps:
- name: Determine signing secret name
shell: bash
run: |
case "${{ inputs.target }}" in
qa)
SECRET_NAME="metamask-mobile-qa-signing-certificates"
;;
flask)
SECRET_NAME="metamask-mobile-flask-signing-certificates"
;;
main)
SECRET_NAME="metamask-mobile-main-signing-certificates"
;;
*)
echo "❌ Unknown target: ${{ inputs.target }}"
exit 1
;;
esac
echo "AWS_SIGNING_CERT_SECRET_NAME=$SECRET_NAME" >> "$GITHUB_ENV"

- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v4
with:
role-to-assume: ${{ inputs.aws-role-to-assume }}
aws-region: ${{ inputs.aws-region }}

- name: Fetch secret and export as environment variables
shell: bash
run: |
echo "🔐 Fetching secret from Secrets Manager..."
secret_json=$(aws secretsmanager get-secret-value \
--region "${{ inputs.aws-region }}" \
--secret-id "${AWS_SIGNING_CERT_SECRET_NAME}" \
--query SecretString \
--output text)

keys=$(echo "$secret_json" | jq -r 'keys[]')
for key in $keys; do
value=$(echo "$secret_json" | jq -r --arg k "$key" '.[$k]')
echo "::add-mask::$value"
echo "$key=$(printf '%s' "$value")" >> "$GITHUB_ENV"
echo "✅ Set secret for key: $key"
done

- name: Configure Android Signing Certificates
if: inputs.platform == 'android'
shell: bash
run: |
echo "📦 Configuring Android keystore..."
if [[ -z "$ANDROID_KEYSTORE" ]]; then
echo "⚠️ ANDROID_KEYSTORE is not set. Skipping keystore decoding."
exit 1
fi

# Use provided path if set, fallback to default
KEYSTORE_PATH="${ANDROID_KEYSTORE_PATH:-/tmp/android.keystore}"
echo "$ANDROID_KEYSTORE" | base64 --decode > "$KEYSTORE_PATH"
echo "✅ Android keystore written to $KEYSTORE_PATH"

- name: Configure iOS Signing Certificates
if: inputs.platform == 'ios'
shell: bash
run: |
echo "📦 Configuring iOS code signing..."

# Create paths
CERT_PATH="$RUNNER_TEMP/build_certificate.p12"
PROFILE_PATH="$RUNNER_TEMP/build_pp.mobileprovision"
KEYCHAIN_PATH="$RUNNER_TEMP/app-signing.keychain-db"
CERT_PW="${IOS_SIGNING_KEYSTORE_PASSWORD}"

# Decode base64 files
echo "$IOS_SIGNING_KEYSTORE" | base64 --decode > "$CERT_PATH"
echo "$IOS_SIGNING_PROFILE" | base64 --decode > "$PROFILE_PATH"
echo "✅ Decoded .p12 and provisioning profile"

# Create and unlock keychain
security create-keychain -p "$CERT_PW" "$KEYCHAIN_PATH"
security set-keychain-settings -lut 21600 "$KEYCHAIN_PATH"
security unlock-keychain -p "$CERT_PW" "$KEYCHAIN_PATH"

# Import cert
echo "🔐 Importing certificate..."
if ! security import "$CERT_PATH" -P "$CERT_PW" -A -t cert -f pkcs12 -k "$KEYCHAIN_PATH"; then
echo "❌ Failed to import certificate. Check if the password is correct or the .p12 is valid."
exit 1
fi
echo "✅ Certificate imported"

# Set key partition list
echo "🔑 Setting key partition list..."
if ! security set-key-partition-list -S apple-tool:,apple: -k "$CERT_PW" "$KEYCHAIN_PATH" 2>/dev/null; then
echo "❌ Failed to set key partition list. Codesigning tools may not have access."
exit 1
fi
echo "✅ Key partition list set"


# Verify signing identities
echo "🔍 Verifying code signing identities in keychain..."
IDENTITIES=$(security find-identity -p codesigning "$KEYCHAIN_PATH")

if ! echo "$IDENTITIES" | grep -q "Valid identities"; then
echo "❌ No valid code signing identities found in keychain."
echo "$IDENTITIES"
exit 1
fi

# Extract and print alias (first CN string)
CERT_ALIAS=$(echo "$IDENTITIES" | awk -F '"' '/"Apple/ {print $2; exit}')
if [[ -n "$CERT_ALIAS" ]]; then
echo "✅ Code signing identity available: $CERT_ALIAS"
else
echo "✅ Code signing identity is available (alias not parsed)"
fi

# Install provisioning profile
mkdir -p ~/Library/MobileDevice/Provisioning\ Profiles
cp "$PROFILE_PATH" ~/Library/MobileDevice/Provisioning\ Profiles/
echo "✅ Installed provisioning profile"

echo "Configuring default keychain"
security default-keychain -s "$KEYCHAIN_PATH"
echo "✅ default keychain set"

Loading
Loading