-
Notifications
You must be signed in to change notification settings - Fork 4
Feat/setting/eslint setting/DEVING-31 #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/setting/eslint setting/DEVING-31 #5
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git โ๏ธ
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis update reorganizes and enhances project configuration and quality control. The pull request template has been streamlined with renamed and restructured sections for improved clarity. New GitHub Actions workflows have been added for automated pull request checking and labeling. Additionally, configuration files for Prettier, ESLint, Tailwind, PostCSS, and Jest have been updated or introduced. Test files have been added to verify functionality, and key internal modules and TypeScript configurations have been adjusted accordingly. Changes
Sequence Diagram(s)sequenceDiagram
participant PR as "Pull Request"
participant GH as "GitHub Actions"
participant Repo as "Repository"
participant CI as "CI Jobs"
PR->>GH: Open/Synchronize Pull Request
GH->>Repo: Checkout repository
Repo-->>GH: Code checked out
GH->>CI: Run Node setup, install dependencies
CI->>CI: Execute lint, format, type-check, tests, build
CI->>GH: Report check status
GH->>PR: Post status comment on PR
sequenceDiagram
participant PR as "Pull Request"
participant GH as "GitHub Actions"
participant API as "GitHub API"
PR->>GH: Open/Update Pull Request
GH->>API: Fetch commit messages
API-->>GH: Return commit list
GH->>GH: Parse commit prefixes and determine labels
GH->>API: Apply labels to PR
Poem
๐ชง TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
๐งน Nitpick comments (9)
jest.setup.ts (1)
3-7: Consider enhancing the console.error mock implementation.While the current implementation works for ignoring 'fetchPriority' messages, it could be more robust by:
- Calling the original implementation for other cases
- Adding type safety
Here's an improved implementation:
-jest.spyOn(console, 'error').mockImplementation((message) => { - if (message.includes('fetchPriority')) { - return; - } -}); +const originalConsoleError = console.error; +jest.spyOn(console, 'error').mockImplementation((message: string, ...args: unknown[]) => { + if (message.includes('fetchPriority')) { + return; + } + originalConsoleError.call(console, message, ...args); +});__tests__/page.test.tsx (1)
5-13: Add more comprehensive test cases.The current test suite only checks for the presence of a heading. Consider adding more test cases to verify:
- The actual content of the heading
- Other important elements in the Home component
- Any interactive elements or user interactions
Would you like me to help generate additional test cases?
๐งฐ Tools
๐ช GitHub Actions: PR Check
[error] 9-9: TestingLibraryElementError: Unable to find an accessible element with the role 'heading'.
jest.config.ts (2)
5-8: Add type safety to the configuration setup.Consider adding type annotations to improve type safety:
-const createJestConfig = nextJest({ +const createJestConfig = nextJest<Config>({ dir: './', });
11-22: Consider adding recommended Jest configuration options.The configuration could benefit from additional settings:
const config: Config = { coverageProvider: 'v8', testEnvironment: 'jsdom', setupFilesAfterEnv: ['<rootDir>/jest.setup.ts'], + testMatch: ['**/__tests__/**/*.ts?(x)', '**/?(*.)+(spec|test).ts?(x)'], + testTimeout: 10000, + coverageThreshold: { + global: { + branches: 80, + functions: 80, + lines: 80, + statements: 80, + }, + }, moduleNameMapper: {eslint.config.mjs (2)
22-29: Refine ignore patterns to be more specific.The current patterns might be too broad or missing common test directories:
**/*.jsignores all JavaScript files, which might skip necessary files- Missing common test directories that should be ignored
ignores: [ 'node_modules/', 'dist/', 'public/', '.next/', - '**/*.js', + 'build/**/*.js', + 'coverage/', + '__tests__/**/*.js', 'next-env.d.ts', ],
58-82: Consider adding recommended TypeScript and React rules.The configuration could benefit from additional strict rules:
rules: { 'prettier/prettier': ['error', { endOfLine: 'auto' }], 'react/jsx-filename-extension': [ 'warn', { extensions: ['.tsx', '.jsx'] }, ], + '@typescript-eslint/explicit-function-return-type': ['error', { + allowExpressions: true, + allowTypedFunctionExpressions: true, + }], + '@typescript-eslint/strict-boolean-expressions': 'error', + 'react/prop-types': 'off', // Since we're using TypeScript + 'react/require-default-props': 'off', // Since we're using TypeScript '@typescript-eslint/no-unused-vars': [.github/pull_request_template.md (1)
1-20: Enhance the PR template with additional guidance.The template structure is good, but could benefit from more detailed guidance:
## ๐ ์ฃผ์ ์์ ๋ด์ฉ -ex) ๋ณธ์ธ์ด ์์ฑํ ๋ด์ฉ์ ๋ํ ์์ธ ์ค๋ช +ex) +- ๋ณ๊ฒฝ ์ฌํญ์ ๋ํ ์์ธ ์ค๋ช +- ๋ณ๊ฒฝ ์ด์ ๋ฐ ๋ฐฐ๊ฒฝ +- ์ฃผ์ ๊ธฐ์ ์ ๊ฒฐ์ ์ฌํญ ## ๐บ ์คํฌ๋ฆฐ์ท (์ ํ์ฌํญ) +ex) UI ๋ณ๊ฒฝ์ฌํญ์ด ์๋ ๊ฒฝ์ฐ before/after ์คํฌ๋ฆฐ์ท ์ฒจ๋ถ ## ๐ ์ฐธ๊ณ ์ฌํญ ex) ์๋ ผํ ์ , ๋ฆฌ๋ทฐ์ด๊ฐ ์ ํ์๊ฐ ์๋ ์ถ๊ฐ ์ ๋ณด๋ ๋ฌธ์, ์ฐธ๊ณ ๋งํฌ๋ฅผ ํฌํจ. +- [ ] Breaking changes๊ฐ ์๋์? +- [ ] ์ฑ๋ฅ์ ์ํฅ์ ์ฃผ๋ ๋ณ๊ฒฝ์ฌํญ์ธ๊ฐ์? +- [ ] ๋ณด์ ๊ด๋ จ ๋ณ๊ฒฝ์ฌํญ์ด ์๋์? ## ๐ฌ ๋ฆฌ๋ทฐ ์๊ตฌ์ฌํญ -ex) ์ค์ ์ ์ผ๋ก ๋ฆฌ๋ทฐํด์คฌ์ผ๋ฉด ํ๋ ๋ถ๋ถ +ex) +- ์ฝ๋ ๊ตฌ์กฐ๋ ์ค๊ณ์ ๋ํ ํผ๋๋ฐฑ +- ํน์ ๋ก์ง์ด๋ ์๊ณ ๋ฆฌ์ฆ์ ๋ํ ๊ฒํ +- ์ฑ๋ฅ์ด๋ ๋ณด์ ๊ด๋ จ ๊ฒํ ## ๐ ๊ด๋ จ ์ด์ ex) #์ด์ ๋ฒํธ +๊ด๋ จ ์ด์: #XX +ํด๊ฒฐ๋ ์ด์: Closes #XX.prettierrc (1)
14-25: Consider enhancing import order configuration.The import order configuration could be more comprehensive:
"importOrder": [ + "^react$", + "^next(.*)$", "^@utils/(.*)$", "^@apis/(.*)$", "^@hooks/(.*)$", "^@recoils/(.*)$", "^@pages/(.*)$", "^@base/(.*)$", "^@common/(.*)$", "^@components/(.*)$", "^@styles/(.*)$", + "^@types/(.*)$", + "^@tests/(.*)$", "^[./]" ],.github/workflows/pr-labeler.yml (1)
16-42: Add error handling to the labeling script.The script should handle potential API errors gracefully.
script: | + try { const commits = await github.rest.pulls.listCommits({ owner: context.repo.owner, repo: context.repo.repo, pull_number: context.issue.number }); const labels = new Set(); commits.data.forEach(commit => { const msg = commit.commit.message; if (msg.startsWith('feat[')) labels.add('โจ feat'); if (msg.startsWith('fix[')) labels.add('๐ fix'); if (msg.startsWith('style[')) labels.add('๐ style'); if (msg.startsWith('refactor[')) labels.add('โป๏ธ refactor'); if (msg.startsWith('test[')) labels.add('โ test'); if (msg.startsWith('docs[')) labels.add('๐ docs'); if (msg.startsWith('chore[')) labels.add('๐ง chore'); }); if (labels.size > 0) { await github.rest.issues.addLabels({ owner: context.repo.owner, repo: context.repo.repo, issue_number: context.issue.number, labels: Array.from(labels) }); } + } catch (error) { + core.setFailed(`Action failed with error: ${error}`); + }
๐ Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
โ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
๐ Files selected for processing (17)
.github/pull_request_template.md(1 hunks).github/workflows/pr-check.yml(1 hunks).github/workflows/pr-labeler.yml(1 hunks).prettierrc(1 hunks)__tests__/add.test.ts(1 hunks)__tests__/page.test.tsx(1 hunks)eslint.config.mjs(3 hunks)jest.config.ts(1 hunks)jest.setup.ts(1 hunks)package.json(2 hunks)postcss.config.js(1 hunks)postcss.config.mjs(0 hunks)src/app/layout.tsx(1 hunks)src/app/page.tsx(4 hunks)src/util/add.ts(1 hunks)tailwind.config.ts(1 hunks)tsconfig.json(2 hunks)
๐ค Files with no reviewable changes (1)
- postcss.config.mjs
โ Files skipped from review due to trivial changes (4)
- postcss.config.js
- src/app/layout.tsx
- src/app/page.tsx
- tailwind.config.ts
๐งฐ Additional context used
๐ช actionlint (1.7.4)
.github/workflows/pr-check.yml
12-12: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
15-15: the runner of "actions/setup-node@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
40-40: the runner of "actions/github-script@v6" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
.github/workflows/pr-labeler.yml
10-10: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
13-13: the runner of "actions/github-script@v6" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
๐ช GitHub Actions: PR Check
__tests__/page.test.tsx
[error] 9-9: TestingLibraryElementError: Unable to find an accessible element with the role 'heading'.
๐ Additional comments (10)
__tests__/add.test.ts (1)
1-5: LGTM!The test is well-structured, clear, and follows testing best practices.
src/util/add.ts (1)
1-5: LGTM!The implementation is clean, well-typed, and follows TypeScript best practices.
jest.config.ts (1)
24-25: LGTM!The export is correctly implemented with a helpful comment explaining the async nature of Next.js config.
eslint.config.mjs (1)
19-19: LGTM!The TypeScript type annotation improves type safety of the configuration.
.prettierrc (1)
10-13: LGTM!The addition of @trivago/prettier-plugin-sort-imports is a good choice for maintaining consistent import ordering.
tsconfig.json (2)
5-5: LGTM! Jest types configuration added.The addition of Jest types aligns well with the new testing setup in the project.
22-32: LGTM! Well-structured path aliases configuration.The path aliases are well-organized and follow a consistent pattern, making imports cleaner and more maintainable.
package.json (3)
10-10: LGTM! Improved lint:fix script path.The lint:fix script now correctly targets only the src directory.
49-49: LGTM! TypeScript version downgrade.The TypeScript version has been correctly downgraded to 5.5.0 to resolve compatibility issues with @typescript-eslint/typescript-estree, as mentioned in the PR objectives.
23-25: Verify @testing-library/react version compatibility.The @testing-library/react version seems outdated compared to other testing dependencies.
โ Incorrect review comment
๐ Web query:
What is the latest version of @testing-library/react?๐ก Result:
The latest version of
@testing-library/reactis 16.2.0, released approximately one month ago as of February 2025[1][7]. This version requires explicit installation of peer dependencies including@testing-library/domand@types/react-domfor TypeScript users[1][7].Key details about recent updates:
- Breaking changes in v16.0.0 (June 2024):
@testing-library/dombecame a required peer dependency- TypeScript users must manually install
@types/react-dom[1]- React 18+ compatibility:
- Versions 13+ require React 18
- Legacy React versions (17 or older) must use v12[7]
- New testing patterns:
- Built-in
renderHooksupport now exists directly in@testing-library/react(no separate hooks library needed)[4]- Improved async utilities and timer handling[6]
For new projects, the recommended installation command is:
npm install --save-dev @testing-library/react @testing-library/domDevelopers upgrading from versions before 16 should pay special attention to peer dependency requirements and type definitions[1][7][9].
Citations:
- 1: https://github.com/testing-library/react-testing-library/releases
- 2: https://www.npmpeer.dev/packages/@testing-library/react/compatibility
- 3: https://github.com/testing-library/react-hooks-testing-library/releases
- 4: https://github.com/testing-library/react-hooks-testing-library
- 5: https://testing-library.com/docs/example-react-router/
- 6: https://www.dhiwise.com/post/top-react-testing-libraries-2023-latest-updates-and-improvements
- 7: https://www.npmjs.com/package/@testing-library/react
- 8: https://legacy.reactjs.org/versions
- 9: https://testing-library.com/docs/react-testing-library/intro/
- 10: https://github.com/testing-library/react-testing-library/blob/main/CHANGELOG.md
@testing-library/react is Up-To-Date
After verifying the latest version, the web query confirms that version 16.2.0 is current. Since the package.json already specifies this version, the review comment regarding it being outdated is not applicable.
- The installed version matches the latest release.
- No changes are needed to address compatibility.
Likely an incorrect or invalid review comment.
__tests__/page.test.tsx
Outdated
| it('renders a heading', () => { | ||
| render(<Home />); | ||
|
|
||
| const heading = screen.getByRole('heading'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the failing test by being more specific about the heading.
The test is failing because it cannot find a heading element. This could be because:
- The Home component doesn't have any heading elements
- The heading might have a specific text or level that we should query for
Consider these improvements:
- const heading = screen.getByRole('heading');
+ const heading = screen.getByRole('heading', {
+ // Add specific criteria, e.g.:
+ name: /welcome to moim/i, // if you expect specific text
+ level: 1 // if you expect a specific heading level (h1)
+ });๐ Committable suggestion
โผ๏ธ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| const heading = screen.getByRole('heading'); | |
| const heading = screen.getByRole('heading', { | |
| // Add specific criteria, e.g.: | |
| name: /welcome to moim/i, // if you expect specific text | |
| level: 1 // if you expect a specific heading level (h1) | |
| }); |
๐งฐ Tools
๐ช GitHub Actions: PR Check
[error] 9-9: TestingLibraryElementError: Unable to find an accessible element with the role 'heading'.
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๐ ๏ธ Refactor suggestion
Update GitHub Actions to latest versions.
The workflow uses older versions of GitHub Actions. Update to the latest versions for improved features and security:
- actions/checkout@v3 โ actions/checkout@v4
- actions/setup-node@v3 โ actions/setup-node@v4
- actions/github-script@v6 โ actions/github-script@v7
Also applies to: 15-15, 40-40
๐งฐ Tools
๐ช actionlint (1.7.4)
12-12: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
.github/workflows/pr-check.yml
Outdated
| const status = ${{ job.status }}; | ||
| const emoji = status === 'success' ? 'โ ' : 'โ'; | ||
| const body = `${emoji} CI Status: ${status}\n\n๊ฒ์ฌ ํญ๋ชฉ:\n- Lint\n- Format\n- Type Check\n- Tests\n- Build`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๐ ๏ธ Refactor suggestion
Fix template literal syntax in GitHub Script.
The current syntax for status interpolation could cause issues. Use proper template literal syntax:
- const status = ${{ job.status }};
- const emoji = status === 'success' ? 'โ
' : 'โ';
- const body = `${emoji} CI Status: ${status}\n\n๊ฒ์ฌ ํญ๋ชฉ:\n- Lint\n- Format\n- Type Check\n- Tests\n- Build`;
+ const status = context.job.status;
+ const emoji = status === 'success' ? 'โ
' : 'โ';
+ const body = `${emoji} CI Status: ${status}\n\n๊ฒ์ฌ ํญ๋ชฉ:\n- Lint\n- Format\n- Type Check\n- Tests\n- Build`;๐ Committable suggestion
โผ๏ธ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| const status = ${{ job.status }}; | |
| const emoji = status === 'success' ? 'โ ' : 'โ'; | |
| const body = `${emoji} CI Status: ${status}\n\n๊ฒ์ฌ ํญ๋ชฉ:\n- Lint\n- Format\n- Type Check\n- Tests\n- Build`; | |
| const status = context.job.status; | |
| const emoji = status === 'success' ? 'โ ' : 'โ'; | |
| const body = `${emoji} CI Status: ${status}\n\n๊ฒ์ฌ ํญ๋ชฉ:\n- Lint\n- Format\n- Type Check\n- Tests\n- Build`; |
| label: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๐ ๏ธ Refactor suggestion
Update GitHub Actions to latest versions.
Similar to pr-check.yml, update to the latest versions:
- actions/checkout@v3 โ actions/checkout@v4
- actions/github-script@v6 โ actions/github-script@v7
Also applies to: 13-13
๐งฐ Tools
๐ช actionlint (1.7.4)
10-10: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
|
โ CI Status: undefined ๊ฒ์ฌ ํญ๋ชฉ:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
๐งน Nitpick comments (1)
.github/workflows/pr-check.yml (1)
42-58: Consider using English for status messages.The status message includes Korean text (
๊ฒ์ฌ ํญ๋ชฉ). For better accessibility across international teams, consider using English:- const body = `${emoji} CI Status: ${status}\n\n๊ฒ์ฌ ํญ๋ชฉ:\n- Lint\n- Format\n- Type Check\n- Tests\n- Build`; + const body = `${emoji} CI Status: ${status}\n\nChecks:\n- Lint\n- Format\n- Type Check\n- Tests\n- Build`;๐งฐ Tools
๐ช actionlint (1.7.4)
44-44: the runner of "actions/github-script@v6" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
๐ Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
๐ Files selected for processing (2)
.github/workflows/pr-check.yml(1 hunks).github/workflows/pr-labeler.yml(1 hunks)
๐งฐ Additional context used
๐ช actionlint (1.7.4)
.github/workflows/pr-labeler.yml
15-15: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
18-18: the runner of "actions/github-script@v6" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
.github/workflows/pr-check.yml
16-16: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
19-19: the runner of "actions/setup-node@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
44-44: the runner of "actions/github-script@v6" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
๐ Additional comments (6)
.github/workflows/pr-check.yml (3)
3-9: LGTM!The permissions and trigger events are correctly configured for PR checks.
16-16: Update GitHub Actions to latest versions.The workflow uses older versions of GitHub Actions. Update to the latest versions for improved features and security:
- actions/checkout@v3 โ actions/checkout@v4
- actions/setup-node@v3 โ actions/setup-node@v4
- actions/github-script@v6 โ actions/github-script@v7
Also applies to: 19-19, 44-44
๐งฐ Tools
๐ช actionlint (1.7.4)
16-16: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
24-40: LGTM!The check steps are well-organized and cover all essential aspects of code quality.
.github/workflows/pr-labeler.yml (3)
15-15: Update GitHub Actions to latest versions.Similar to pr-check.yml, update to the latest versions:
- actions/checkout@v3 โ actions/checkout@v4
- actions/github-script@v6 โ actions/github-script@v7
Also applies to: 18-18
๐งฐ Tools
๐ช actionlint (1.7.4)
15-15: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
27-37: LGTM!The labeling logic is well-structured and follows conventional commit format. The use of emojis in labels improves visibility.
46-48: LGTM!The error handling is appropriately implemented with informative error messages.
CI Status Report๊ฒ์ฌ ๊ฒฐ๊ณผ
โ ๋ชจ๋ ๊ฒ์ฌ๊ฐ ํต๊ณผ๋์์ต๋๋ค. |
dbswl701
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI Status Report๊ฒ์ฌ ๊ฒฐ๊ณผ
โ ๋ชจ๋ ๊ฒ์ฌ๊ฐ ํต๊ณผ๋์์ต๋๋ค. |
dbswl701
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๊ณ ์ํ์ จ์ต๋๋ค!
ade5f7d
CI Status Report๊ฒ์ฌ ๊ฒฐ๊ณผ
โ ๋ชจ๋ ๊ฒ์ฌ๊ฐ ํต๊ณผ๋์์ต๋๋ค. |
Welcome to Codecov ๐Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. โน๏ธ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered โ๏ธ |

๐ย ์ฃผ์ ์์ ๋ด์ฉ
๋ฆฐํธ์ ํ๋ฆฌํฐ์ด ์ฌ์ค์ ๋ฐ github workflows ์ ๋ผ๋ฒจ๋ง๊ณผ pr-check์ถ๊ฐํ์์ต๋๋ค.
๐บย ์คํฌ๋ฆฐ์ท
๋ผ๋ฒจ๋ง์ ์ปค๋ฐ๋ฉ์์ง ์ปจ๋ฒค์ ์ ์์กดํฉ๋๋ค.
๐ ์ฐธ๊ณ ์ฌํญ
import ์ ๋ ฌ ์์ ๋ณด์ฅ ์ํ
npm install -D @trivago/prettier-plugin-sort-imports
ํจํค์ง ์ถ๊ฐ.
npm run lint:fix ์งํ์,
WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.
You may find that it works just fine, or you may not.
SUPPORTED TYPESCRIPT VERSIONS: >=4.7.4 <5.6.0
YOUR TYPESCRIPT VERSION: 5.7.3
Please only submit bug reports when using the officially supported version.
=============
TypeScript ๋ฒ์ ๋ฌธ์ : ํ์ฌ TypeScript 5.7.3์ ์ฌ์ฉ ์ค์ธ๋ฐ, @typescript-eslint๊ฐ ์ง์ํ๋ ๋ฒ์ ์ 4.7.4 ~ 5.6.0์ ๋๋ค.
.next ํด๋์ ํ์ผ๋ค์ด tsconfig.json์ ํฌํจ๋์ด ์์ง ์์์ ๋ฐ์ํ๋ ๋ฌธ์ ์ ๋๋ค.
๋ฐ๋ผ ํ์ ์คํฌ๋ฆฝํธ ๋ฒ์ ์ 5.5.4๋ก ๋ณ๊ฒฝํ์์ต๋๋ค. ๋ํ lint๋, srcํ์ํด๋์๋ง ์ํํ๋๋ก ์ค์ ํ์์ต๋๋ค.
๐ฌย ๋ฆฌ๋ทฐ ์๊ตฌ์ฌํญ
ex) ์ค์ ์ ์ผ๋ก ๋ฆฌ๋ทฐํด์คฌ์ผ๋ฉด ํ๋ ๋ถ๋ถ
๐ย ๊ด๋ จ ์ด์
DEVING-31
Summary by CodeRabbit