[core][Matrix] Implement full support for Matrix views #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iterator returns mutable views.
Collaborator
Author
forfudan
approved these changes
Dec 3, 2025
forfudan
approved these changes
Dec 3, 2025
Collaborator
forfudan
left a comment
forfudan
left a comment
There was a problem hiding this comment.
May I suggest to rename MatrixImpl into MatrixBase? As the type hint always show the name of this type instead of the alias Matrix, users may wonder what is a MatrixImpl. MatrixBase looks be more natural.
shivasankarka
merged commit cb5ead4
into
Mojo-Numerics-and-Algorithms-group:pre-0.8
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more details on the new Matrix view model, refer to #279 where I have explained the updated (2025/11/22) model as of Mojo 25.7