Skip to content

Refactors Scrying Code#5072

Draft
realforest2001 wants to merge 10 commits intoMonkestation:mainfrom
realforest2001:forest/scrying
Draft

Refactors Scrying Code#5072
realforest2001 wants to merge 10 commits intoMonkestation:mainfrom
realforest2001:forest/scrying

Conversation

@realforest2001
Copy link
Collaborator

About The Pull Request

As the title, making an effort to have scrying be a little easier to add to items as it's redefined in a few places.
I plan to change how it actually works so you're not jumping between mobs, but that'll either be pushed later or in another PR.

Why It's Good For The Game

Makes life easier for future changes.

Changelog

🆑
refactor: Refactored how scrying is attached to objects.
/:cl:

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

@github-actions github-actions bot added the Code Maintenance Fixing this mess one line at a time label Jan 29, 2026
var/cooldown_duration = 30 SECONDS
COOLDOWN_DECLARE(scry_cooldown)

/datum/scrying_component/New()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add cleanup if scrying component is deleted (e.g. parent is deleted)

@realforest2001 realforest2001 marked this pull request as draft January 29, 2026 16:17
This was referenced Feb 3, 2026
@realforest2001 realforest2001 marked this pull request as ready for review February 6, 2026 03:03
@realforest2001 realforest2001 marked this pull request as draft February 13, 2026 22:02
@realforest2001
Copy link
Collaborator Author

Still need to do black mirror

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Maintenance Fixing this mess one line at a time

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants