[graphql-alt] Load balanceChanges from simulate and execute transaction #24338
+161
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpham-mysten
requested review from
amnn,
emmazzz,
evan-wall-mysten,
henryachen and
wlmyng
tpham-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
tpham-mysten
commented
Nov 19, 2025
| #[derive(Clone)] | ||
| /// Effects to the balance (sum of coin values per coin type) of addresses and objects. | ||
| #[derive(Clone, SimpleObject)] | ||
| pub(crate) struct BalanceChange { |
Contributor
Author
There was a problem hiding this comment.
For this change, I have been thinking on a few options:
- Keep
storedfield and add a new constructorfrom_grpc(&GrpcBalanceChange)to convertGrpcBalanceChangetoStoredBalanceChange. However,StoredBalanceChangeis having owner type, whereGrpcBalanceChangeis just having address. We could overcome it by just usingAddressOwnerto wrap the address (as it will be unwrapped to address anyway), but that logic can be confusing to readers as they might thinkSuiAddressis alwaysAddressOwner? - Replace "stored: StoredBalanceChange" by the native BalanceChanges from
sui-types. This works but requires extra conversion for both gpc::BalanceChange and stored::BalanceChange, making the flow more complex. - [This approach] convert the
gpc::BalanceChangeandstored::BalanceChangedirectly toSimpleObjectBalanceChange, which allows us to convert theBalanceChangedirectly to GraphQL type.
Contributor
There was a problem hiding this comment.
I like this approach for this use case!
tpham-mysten
force-pushed
the
tpham-graphql-balance-changes
branch
from
9d79779 to
20bea81
Compare
tpham-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
amnn
reviewed
Nov 20, 2025
Contributor
amnn
left a comment
amnn
left a comment
There was a problem hiding this comment.
Could we expose the balance changes through the transaction effects contents, rather than through the scope?
| #[derive(Clone)] | ||
| /// Effects to the balance (sum of coin values per coin type) of addresses and objects. | ||
| #[derive(Clone, SimpleObject)] | ||
| pub(crate) struct BalanceChange { |
Contributor
There was a problem hiding this comment.
I like this approach for this use case!
|
|
||
| // Load balance changes from database using DataLoader | ||
| // First try to get balance changes from execution context (scope) | ||
| if let Some(grpc_balance_changes) = self.scope.balance_changes() { |
Contributor
There was a problem hiding this comment.
I'm surprised to see this in the scope, as opposed to being exposed via the content, like for events -- why is that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Transactions that are output from simulation don't produce balance changes (because the usual path for returning balance changes involves looking them up in the database). This PR fixes that by loading the balance changes from the gRPC response.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.