Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unimplemented notification page #241

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rileychh
Copy link
Member

@rileychh rileychh commented Dec 4, 2024

Description

This PR removes the unimplemented notification page from the project. This includes cleaning up associated localization strings, dependencies, and unused code. The notification page was previously a placeholder and is no longer planned for implementation.

Implementation

  • Removed NotificationPage widget and its related file (lib/ui/pages/notification/notification_page.dart).
  • Updated MainScreen to exclude the notification page from the navigation structure.
  • Deleted the titleNotification localization strings from all relevant localization files (intl_en.dart, intl_zh_TW.dart, intl_en.arb, intl_zh_TW.arb).
  • Cleaned up references to titleNotification in the generated localization classes (S).
  • Verified the removal of references in the codebase to avoid broken dependencies.

Breaking Changes

  • Removed a navigation tab for the notification page, which may affect users if the page was accessible via routes or other manual integrations.

Testing Instructions

  1. Code Review

    • Confirm that all references to NotificationPage and titleNotification have been successfully removed.
    • Verify that there are no remaining imports or calls to the deleted files/classes.
  2. Manual Testing

    • Build and run the app.
    • Verify that the notification tab no longer appears in the bottom navigation bar.
    • Ensure all other tabs and functionality remain unaffected.

Additional Notes

  • The notification page may be reintroduced in the future if required. The removed implementation is available in the commit history for reference.

@rileychh rileychh self-assigned this Dec 4, 2024
@rileychh rileychh added this to the 1.7 milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant