Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unimplemented notification page #241

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: remove unimplemented notification page #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/generated/intl/messages_en.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,6 @@ class MessageLookup extends MessageLookupByLibrary {
"takeSelect": MessageLookupByLibrary.simpleMessage("Take select"),
"time": MessageLookupByLibrary.simpleMessage("Time"),
"titleCourse": MessageLookupByLibrary.simpleMessage("Course"),
"titleNotification": MessageLookupByLibrary.simpleMessage("Notification"),
"titleOther": MessageLookupByLibrary.simpleMessage("Other"),
"titleScore": MessageLookupByLibrary.simpleMessage("Score"),
"totalAverage": MessageLookupByLibrary.simpleMessage("Total average"),
Expand Down
1 change: 0 additions & 1 deletion lib/generated/intl/messages_zh_TW.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,6 @@ class MessageLookup extends MessageLookupByLibrary {
"takeSelect": MessageLookupByLibrary.simpleMessage("實得選修"),
"time": MessageLookupByLibrary.simpleMessage("時間"),
"titleCourse": MessageLookupByLibrary.simpleMessage("課表"),
"titleNotification": MessageLookupByLibrary.simpleMessage("訊息"),
"titleOther": MessageLookupByLibrary.simpleMessage("其它"),
"titleScore": MessageLookupByLibrary.simpleMessage("成績"),
"totalAverage": MessageLookupByLibrary.simpleMessage("總平均"),
Expand Down
10 changes: 0 additions & 10 deletions lib/generated/l10n.dart
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions lib/l10n/intl_en.arb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@
"fileNameAlreadyExists": "A File with that name already exists!",
"renameItem": "Rename item",
"rename": "Rename",
"titleNotification": "Notification",
"delete": "Delete",
"download": "download",
"downloadWillStart": "Download ready to start",
Expand Down Expand Up @@ -268,4 +267,4 @@
"nationalTaipeiUniversity": "NTPU",
"taipeiMedicineUniversity": "TMU",
"aduit": "Aduit"
}
}
3 changes: 1 addition & 2 deletions lib/l10n/intl_zh_TW.arb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@
"fileNameAlreadyExists": "檔案名稱已經存在!",
"renameItem": "重新命名",
"rename": "重新命名",
"titleNotification": "訊息",
"delete": "刪除",
"download": "下載",
"downloadWillStart": "下載準備開始",
Expand Down Expand Up @@ -268,4 +267,4 @@
"nationalTaipeiUniversity": "國立臺北大學",
"taipeiMedicineUniversity": "臺北醫學大學",
"aduit": "隨班附讀"
}
}
38 changes: 0 additions & 38 deletions lib/ui/pages/notification/notification_page.dart
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions lib/ui/screen/main_screen.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import 'package:flutter_app/src/version/app_version.dart';
import 'package:flutter_app/ui/other/my_toast.dart';
import 'package:flutter_app/ui/pages/calendar/calendar_page.dart';
import 'package:flutter_app/ui/pages/coursetable/course_table_page.dart';
import 'package:flutter_app/ui/pages/notification/notification_page.dart';
import 'package:flutter_app/ui/pages/other/other_page.dart';
import 'package:flutter_app/ui/pages/score/score_page.dart';
import 'package:provider/provider.dart';
Expand Down Expand Up @@ -77,7 +76,6 @@ class _MainScreenState extends State<MainScreen> with RouteAware {
setState(() {
_pageList = [];
_pageList.add(const CourseTablePage());
_pageList.add(const NotificationPage());
_pageList.add(const CalendarPage());
_pageList.add(const ScoreViewerPage());
_pageList.add(OtherPage(_pageController));
Expand Down Expand Up @@ -149,12 +147,6 @@ class _MainScreenState extends State<MainScreen> with RouteAware {
),
label: R.current.titleCourse,
),
BottomNavigationBarItem(
icon: const Icon(
EvaIcons.emailOutline,
),
label: R.current.titleNotification,
),
BottomNavigationBarItem(
icon: const Icon(
EvaIcons.calendarOutline,
Expand Down
Loading