Skip to content

Conversation

@grantfirl
Copy link

@grantfirl grantfirl commented Jan 9, 2026

Description of changes

This PR should have no actual effect on CMEPS. The CCPP suite that CMEPS is calling contains 2 schemes that have changed interfaces from ufs-community/ccpp-physics#298. Specifically, more variables are required by GFS_surface_composites_pre/post. This PR simply adds these variables to the typedefs and metadata so that CMEPS can successfully compile and run with the ccpp-physics changes. The behavior of the 2 schemes with changed interfaces should not change as long as the preprocessor directive CDEPS_INLINE is not defined (by default) and the USE_CDEPS_INLINE environment variable is set to False (by default).

Specific notes

Contributors other than yourself, if any:
@uturuncoglu

CMEPS Issues Fixed (include github issue #):
None

Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)
Should be b4b

Any User Interface Changes (namelist or namelist defaults changes)?
No

Testing performed

Please describe the tests along with the target model and machine(s)
If possible, please also added hashes that were used in the testing

UFS RTs on Ursa

@NickSzapiro-NOAA
Copy link
Collaborator

So CMEPS already has a separate, existing CDEPS_INLINE directive. Are these starting to conflict since we set -DCDEPS_INLINE=ON in compile at ufs-weather-model level?

@grantfirl
Copy link
Author

So CMEPS already has a separate, existing CDEPS_INLINE directive. Are these starting to conflict since we set -DCDEPS_INLINE=ON in compile at ufs-weather-model level?

@uturuncoglu This is probably a question for you. How do the functionalities differ? Can CDEPS inherit the CDEPS_inline from ufs-weather-model?

@gspetro-NOAA
Copy link

Could we get another review on this sub-PR so that we can process WM parent PR 2807?

@gspetro-NOAA
Copy link

gspetro-NOAA commented Jan 15, 2026

@grantfirl @NickSzapiro-NOAA Who else should review this PR? We need one more review here to schedule WM 2807.

EDIT: We have decided to begin testing on WM PR 2807 since this sub-PR does have one approval, but the sooner someone can add the second review, the better.

@grantfirl
Copy link
Author

@grantfirl @NickSzapiro-NOAA Who else should review this PR? We need one more review here to schedule WM 2807.

EDIT: We have decided to begin testing on WM PR 2807 since this sub-PR does have one approval, but the sooner someone can add the second review, the better.

@gspetro-NOAA I don't know who develops in this repo other than those already listed as reviewers.

@DeniseWorthen
Copy link
Collaborator

@gspetro-NOAA That would be me...I've approved now.

@BrianCurtis-NOAA
Copy link
Collaborator

Upstream testing finished. This can be merged.

@DeniseWorthen DeniseWorthen merged commit 4bb06b3 into NOAA-EMC:emc/develop Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants