GDASApp companion to GW PR #4356 #2014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidNew-NOAA
requested review from
AndrewEichmann-NOAA,
CoryMartin-NOAA and
guillaumevernieres
26 tasks
AndrewEichmann-NOAA
approved these changes
Dec 18, 2025
Collaborator
AndrewEichmann-NOAA
left a comment
AndrewEichmann-NOAA
left a comment
There was a problem hiding this comment.
No problems spotted
guillaumevernieres
approved these changes
Dec 18, 2025
Contributor
guillaumevernieres
left a comment
guillaumevernieres
left a comment
There was a problem hiding this comment.
Thanks @DavidNew-NOAA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds two J2-templated namelists to
parm/marinethat replaceparm/marine/fms/input.nml.j2. This allows me to remove a call to theprep_input_nml()in GW in NOAA-EMC/global-workflow#4356.I'm leaving
parm/marine/fms/input.nml.j2around for now so I can merge this PR without breaking GW before my GW PR merges. All this PR does is add two templates, so it can't break anything.Companion PRs
NOAA-EMC/global-workflow#4356
Issues
NOAA-EMC/global-workflow#4355
Automated CI tests to run in Global Workflow
N/A - These changes will be tested in full CI suite for GW companion PR.