-
Notifications
You must be signed in to change notification settings - Fork 204
Remove remaining calls to routines in marine_da_utils.py #4356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove remaining calls to routines in marine_da_utils.py #4356
Conversation
|
@aerorahul @DavidHuber-NOAA This PR is ready for review |
TravisElless-NOAA
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things look alright to me. Approve pending testing. Will launch CI on Ursa
aerorahul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. thanks. Just one suggestion to pop out the relevant error information in the traceback
71a9f2c
TravisElless-NOAA
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI Passed. Merging
|
Thanks @TravisElless-NOAA |
Description
This PR removes calls to legacy routines in
ush/python/pygfs/utils/marine_da_utils.py. Most of these calls were removed in previous PRs, and this one cleans up the remainder.The code in
get_mom6_levels()was moved into theAnalysisclass constructor and , so the number of mom6 levels becomes part oftask_config, available for all marine tasks.prep_input_yaml()is replaced by simply creating two.nml.j2templates in GDASApp (rather than one) and invoking the newparse_j2tmplfromwxflow.gen_bkg_list()was only called once inush/python/pygfs/task/marine_analysis.py, so I moved its code into the constructor for theMarineAnalysistask.test_hist_date()was only called inush/python/pygfs/task/marine_analysis.py, so I made it a static method of theMarineAnalysistask.run()is moved into theAnalysisclass.Resolves #4355
Type of change
Change characteristics
How has this been tested?
Clone, build, and CI on Hera
Checklist