Add option to override all filters with a global setting #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds functionality to completely override observation filters with global settings for specified observation types. This enables centralized control over quality control flags and other filter configurations across multiple observations.
- Adds
replace_obs_filtersconfiguration option to override filters for specific observations - New logic in the
render()method to selectively replace observation filters based on configuration - Comments out the rdas client configuration in
jcb_clients.yaml
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/jcb/renderer.py | Implements the filter override logic within the render method, adding support for replace_obs_filters configuration to replace all filter types with a global override |
| jcb_clients.yaml | Comments out the rdas client configuration (appears unrelated to the main feature) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
CoryMartin-NOAA
approved these changes
Dec 5, 2025
Contributor
CoryMartin-NOAA
left a comment
CoryMartin-NOAA
left a comment
There was a problem hiding this comment.
Looks great, and simple enough, thanks @danholdaway
CoryMartin-NOAA
added a commit
to NOAA-EMC/jcb-gdas
that referenced
this pull request
Jan 2, 2026
The companion PR to NOAA-EMC/jcb#31 offering an example of how to apply the change to just the GOES-16 ABI YAML. Co-authored-by: danholdaway <[email protected]> Co-authored-by: Cory Martin <[email protected]>
DavidNew-NOAA
pushed a commit
to NOAA-EMC/GDASApp
that referenced
this pull request
Jan 6, 2026
The companion PR to NOAA-EMC/jcb#31 offering an example of how to apply the change to just the GOES-16 ABI YAML. Co-authored-by: danholdaway <[email protected]> Co-authored-by: Cory Martin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may be desirable in some cases to have the filters for certain observation types to be completely overwritten with a global setting. For example you could choose to set the QC flags to some predetermined values. This PR add the generic capability to do that.
And example of activating the new option can be seen here: https://github.com/NOAA-EMC/jcb-gdas/compare/feature/override_filters?expand=1