Address some compiler warnings in UFSATM

[NickSzapiro-NOAA]

Description

(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)

One round of straight-forward fixes for some of the compiler warnings raised in compiling cpld_debug_gfsv17 to improve code quality and prepare for operational implementation

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

• Part of Compile warnings in UFS and subcomponents ufs-community/ufs-weather-model#2703

Testing

Tested via ufs-weather-model RTs and compile err logs with Intel and GNU compilers on Ursa

Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Yes
Have the ufs-weather-model regression test been run? On what platform? Yes, Ursa

• Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below. No
• Please commit the regression test log files in your ufs-weather-model branch

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

• waiting on Address some compiler warnings in UFSATM and stochastic physics: round 1 // Broad WM Documentation Update (#2928) ufs-community/ufs-weather-model#2935
• waiting on Reduce "Explicit interface or EXTERNAL declaration is required" compiler warnings in sfcsub ufs-community/ccpp-physics#312
• waiting on Fix intel debug warnings (implicit i,j,k; explicit mpi interface) NOAA-GFDL/GFDL_atmos_cubed_sphere#396

[DusanJovic-NOAA]

@NickSzapiro-NOAA Please add corresponding fv3_dycore PR as a dependency

[NickSzapiro-NOAA]

Thanks @DusanJovic-NOAA. The ufsatm, ccpp-physics, and dycore changes are all independent, if need be

[gspetro-NOAA]

Could we get approvals on this PR so that we can process its GFSv17 priority parent PR? (WM #2935)

[rhaesung]

@NickSzapiro-NOAA ufs-community/ccpp-physics#312 has been merged. Please update the submodule pointer for ccpp-physics (ufs-community/ccpp-physics@14f24db) and revert the .gitmodules file in preparation for the merge.

[gspetro-NOAA]

@NickSzapiro-NOAA Same for NOAA-GFDL/GFDL_atmos_cubed_sphere#396. You can update the atmos_cubed_sphere submodule pointer to b0a1b09.

[NickSzapiro-NOAA]

Sure. Please let me know if ok

[gspetro-NOAA]

@NickSzapiro-NOAA It looks good to me!
We should be set to merge this UFSATM PR next.