Bring in some HAFSv2 related UFSATM developments #1047
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NOAA-EMC#618) * Use 32bit value for 'missing_value' and '_FillValue' attributes
3DTKE related updates from @JongilHan66.
…to feature/hafsv2p2_baseline
…hafsv2p2_baseline
…mpson_noahmp_rrtmgp schemes. - suite_FV3_HAFS_v2_coupled.xml - suite_FV3_HAFS_v2.xml Note: There is a 37-character length limit for suite names.
The following changes are from @RongqianYang-NOAA, @barlage, and @wramstrom, to address NoahMP LSM and sea-ice related moving-nesting issues. - Add snow layer and snow soil layer thickness to GFS_type. - Add checks for soil moisture for Noah MP. - Changes for distinguishing between new and old points for snow-related fields reset in moving nest physics. - Add leading_edge logical array to indicate which nest points have been interpolated. Needed for NOAH MP moving nest upgrades. - NOAHMP moving nest sea ice and cryosphere fixes and added variables tiice, tisfc, sncovr, fice, hice. Notes: Lots of contribution (discussions/diagnostics/debugging/testing) from @ChuankaiWang-NOAA, @yonghuiweng, ZhanZhang-NOAA, @[email protected], @[email protected], @BinLiu-NOAA as well.
…o feature/hafsv2p2_baseline
options of tc_rain and tc_snow for adjustments of max terminal fall speeds of rain and snow under TC conditions.
… Lanczos-like temporal filter
This was referenced Dec 15, 2025
BinLiu-NOAA
commented
Jan 8, 2026
| GFS_Sfcprop%zorlwav(im) = -999.0_GFS_kind_phys | ||
| ! if (GFS_Sfcprop%oceanfrac(im) > zero .and. datar8(i,j) > zorlmin) then | ||
| if (GFS_Sfcprop%oceanfrac(im) > zero) then | ||
| if (mergeflg(i,j)) datar8(i,j)=GFS_Sfcprop%zorlw(im) ! use initial value |
Collaborator
Author
There was a problem hiding this comment.
@DeniseWorthen This section of source code changes were made by @binli2337 previously before he left. If you get a chance, could you please help to review/check if these changes are appropriate? Also, will these modifications change answers for any existing ufs-weather-model coupled Regression Tests? Thanks!
Collaborator
There was a problem hiding this comment.
Did @binli2337 provide an explanation on whatever PR he made in HAFS to bring these changes in?
You'll have to run the full RT to determine if baseline changes occur.
Add RRTMGP initialization flags and revert hardcoding of mpiroot.
….meta, GFS_typedefs.F90, GFS_typedefs.meta so that convective adjustment time can be tunable, introducing two parameters cat_adj_deep and cat_adj_shal for this
rain and snow in Thompson MP scheme
…stment time can be tunable, introducing two parameters cat_adj_deep and cat_adj_shal for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR combines the following HAFS related developments and bring them back to UFSATM and related ufs-weather-model submodules.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?
Technical and retrospective/real-time-parallel testing were conducted with the UFS-HAFS hurricane application.
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs