-
Notifications
You must be signed in to change notification settings - Fork 276
Bring in some HAFSv2 related developments and updates #3014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Bring in some HAFSv2 related developments and updates #3014
Conversation
introducing two Thompson MP related namelist options of tc_rain and tc_snow for adjustments of max terminal fall speeds of rain and snow under TC conditions.
… Lanczos-like temporal filter
…into feature/hafsv2_sync
rain and snow in Thompson MP scheme
|
@BinLiu-NOAA Have you had a chance to run tests on this PR? Before we can schedule it, we'll need you to run the full RT suite (preferably on Ursa, but Hercules or another system would do). You'll also need to fill out the PR template fully; currently, it's missing some information including a commit message and an indication of whether the PR is baseline changing or not. |
|
@BinLiu-NOAA Are you expecting changes to all cpld tests w/ this PR? It didn't seem like the ATM changes would impact anything other than the HAFS configuration, but I'm not sure what your expectation was. |
@DeniseWorthen We are still conducting various testings on multiplatforms to understatnd the RTs result changing. In terms of the RT baseline changes for the following RTs: I suspect it might be related to this code section update in UFSATM (fv3/atmos_model.F90): Please see our conversation in the related PR: With that, I will revert this fv3/atmos_model.F90 change and conduct another full RT to see if these above cpld RT baseline changes will be gone. Thanks! Note: the hafs related RT baseline changes are expected. |
|
@BinLiu-NOAA I remember the conversation---but did Bin provide an explanation of why he was changing that line? It would be helpful to know what the reason was he needed to change it. |
@DeniseWorthen: A follow-up update, by reverting the code changes in UFSATM (fv3/atmos_model.F90), the regression tests on WCOSS2 confirmed that only the following HAFS related RTs got baseline changes/differences (as expected): In terms of whether or not these few lines of changes in UFSATM (fv3/atmos_model.F90) are leftovers or desired, I will take a look at from my end first. If you get a chance, please also review and check the source code changes. Much appreciated! |
Commit Queue Requirements:
test_changes.listindicates which tests, if any, are changed by this PR. Committest_changes.list, even if it is empty.Description:
This PR combines the following HAFS related developments and bring them back to ufs-weather-model and related submodules.
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Documentation:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: