Skip to content

Conversation

@BinLiu-NOAA
Copy link
Contributor

@BinLiu-NOAA BinLiu-NOAA commented Dec 12, 2025

Commit Queue Requirements:

  • This PR addresses a relevant WM issue (if not, create an issue).
  • All subcomponent pull requests (if any) have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). Exceptions: documentation-only PRs, CI-only PRs, etc.
    • Commit log file w/full results from RT suite run (if applicable).
    • Verify that test_changes.list indicates which tests, if any, are changed by this PR. Commit test_changes.list, even if it is empty.
  • Fill out all sections of this template.

Description:

This PR combines the following HAFS related developments and bring them back to ufs-weather-model and related submodules.

  • NoahMP LSM and sea ice related updates for HAFS moving nesting from @RongqianYang-NOAA, @barlage, and @wramstrom. Meanwhile, lots of contribution (discussions/diagnostics/debugging/testing) from @ChuankaiWang-NOAA, @yonghuiweng, ZhanZhang-NOAA, @helin.wei@noaa.gov, @yangfanglin, @BinLiu-NOAA as well.
  • HAFS moving-nesting related 3D-IAU capability. (from @XuLu-NOAA)
  • Enable RRTMGP working with nesting (moving-nesting) configurations. (from @Qingfu-Liu, @dustinswales)
  • Introduce two Thompson MP related namelist options for adjustments of max terminal fall speeds of rain and snow under TC conditions. (from @WeiguoWang-NOAA)
  • Introduce two namelist options of cat_adj_deep and cat_adj_shal to adjust convective adjustment time in SASAS convection scheme. (from @JunghoonShin-NOAA)
  • Update HAFS moving-nesting internal tracker to output moving nest domain location to support the moving-nesting forecast restart capability. (from @BinLiu-NOAA)

Commit Message:

* UFSWM - 
  * UFSATM - 
    * ccpp-physics - 
    * atmos_cubed_sphere - 

Priority:

  • Critical Bugfix: Reason
  • High: HAFSv2.2 upgrade
  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • Blocked by #
  • None

Documentation:

  • Documentation update required.
    • Relevant updates are included with this PR.
    • A WM issue has been opened to track the need for a documentation update; a person responsible for submitting the update has been assigned to the issue (link issue).
  • Documentation update NOT required.
    • Explanation:

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Tests/Baselines.
  • PR Updates/Changes Baselines.
  • No Baseline Changes.

Input data Changes:

  • None.
  • PR adds input data.
  • PR changes existing input data.

Library Changes/Upgrades:

  • Required
    • Library names w/versions:
    • Git Stack Issue (JCSDA/spack-stack#)
  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • GaeaC6
    • Derecho
    • Ursa
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

dustinswales and others added 30 commits January 24, 2025 22:04
   Subscript #1 of the array FARRAYPTR has value 0 which is less than the lower bound of 1 in FV3/cpl/module_cplscalars.F90
XuLu-NOAA and others added 5 commits December 10, 2025 17:33
@BinLiu-NOAA BinLiu-NOAA marked this pull request as ready for review January 20, 2026 14:54
@gspetro-NOAA gspetro-NOAA moved this from Draft to Evaluating in PRs to Process Jan 20, 2026
@gspetro-NOAA gspetro-NOAA moved this from Evaluating to Pre-testing required in PRs to Process Jan 21, 2026
@gspetro-NOAA
Copy link
Collaborator

@BinLiu-NOAA Have you had a chance to run tests on this PR? Before we can schedule it, we'll need you to run the full RT suite (preferably on Ursa, but Hercules or another system would do). You'll also need to fill out the PR template fully; currently, it's missing some information including a commit message and an indication of whether the PR is baseline changing or not.

@gspetro-NOAA gspetro-NOAA added the Baseline Updates Current baselines will be updated. label Jan 22, 2026
@DeniseWorthen
Copy link
Collaborator

@BinLiu-NOAA Are you expecting changes to all cpld tests w/ this PR? It didn't seem like the ATM changes would impact anything other than the HAFS configuration, but I'm not sure what your expectation was.

@BinLiu-NOAA
Copy link
Contributor Author

@BinLiu-NOAA Are you expecting changes to all cpld tests w/ this PR? It didn't seem like the ATM changes would impact anything other than the HAFS configuration, but I'm not sure what your expectation was.

@DeniseWorthen We are still conducting various testings on multiplatforms to understatnd the RTs result changing. In terms of the RT baseline changes for the following RTs:

cpld_control_p8_mixedmode intel
cpld_control_gfsv17 intel
cpld_control_gfsv17_iau intel
cpld_restart_gfsv17 intel
cpld_restart_gfsv17_iau intel
cpld_mpi_gfsv17 intel
cpld_debug_gfsv17 intel
cpld_control_p8 intel
cpld_control_p8.v2.sfc intel
cpld_restart_p8 intel
cpld_control_qr_p8 intel
cpld_restart_qr_p8 intel
cpld_2threads_p8 intel
cpld_decomp_p8 intel
cpld_mpi_p8 intel
cpld_control_ciceC_p8 intel
cpld_control_noaero_p8 intel
cpld_control_pdlib_p8 intel
cpld_restart_pdlib_p8 intel
cpld_mpi_pdlib_p8 intel
cpld_control_c48_5deg intel
cpld_control_c24_5deg intel
cpld_control_c24_9deg intel
cpld_control_c12_9deg intel
cpld_debug_pdlib_p8 intel

I suspect it might be related to this code section update in UFSATM (fv3/atmos_model.F90): Please see our conversation in the related PR:
NOAA-EMC/ufsatm#1047 (comment)

With that, I will revert this fv3/atmos_model.F90 change and conduct another full RT to see if these above cpld RT baseline changes will be gone.

Thanks!

Note: the hafs related RT baseline changes are expected.

@DeniseWorthen
Copy link
Collaborator

@BinLiu-NOAA I remember the conversation---but did Bin provide an explanation of why he was changing that line? It would be helpful to know what the reason was he needed to change it.

@BinLiu-NOAA
Copy link
Contributor Author

@BinLiu-NOAA I remember the conversation---but did Bin provide an explanation of why he was changing that line? It would be helpful to know what the reason was he needed to change it.

@DeniseWorthen: A follow-up update, by reverting the code changes in UFSATM (fv3/atmos_model.F90), the regression tests on WCOSS2 confirmed that only the following HAFS related RTs got baseline changes/differences (as expected):

hafs_regional_specified_moving_1nest_atm intel
hafs_regional_storm_following_1nest_atm intel
hafs_global_storm_following_1nest_atm intel
hafs_regional_storm_following_1nest_atm_ocn_wav_mom6 intel

In terms of whether or not these few lines of changes in UFSATM (fv3/atmos_model.F90) are leftovers or desired, I will take a look at from my end first. If you get a chance, please also review and check the source code changes. Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Baseline Updates Current baselines will be updated. Priority: High

Projects

Status: Pre-testing required

Development

Successfully merging this pull request may close these issues.

Bring in HAFSv2 related updates