-
Notifications
You must be signed in to change notification settings - Fork 176
Combination PR (use FMS tracer_manager for tracer parsing, ECMWF non-stationary GWD changes, other misc. physics changes) #950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge for FMS usage in GFS_typedefs.F90
…ive NO_TRACER value
14 tasks
Collaborator
Author
This was referenced Jun 27, 2025
Contributor
|
@grantfirl ufs-community/ccpp-physics#295 has been merged. Please update the submodule pointer for ccpp-physics ( ufs-community/ccpp-physics@ef272c1) and revert the .gitmodules file in preparation for the merge. |
Collaborator
Author
|
@jkbk2004 Submodule updated and ready for review/merge |
DusanJovic-NOAA
approved these changes
Jul 11, 2025
jkbk2004
approved these changes
Jul 11, 2025
BrianCurtis-NOAA
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains many physics bugfixes and updates described in ufs-community/ccpp-physics#295. The only physics changes requiring changes to the code in fv3atm are as follows:
get_tracer_indexfunction already exists within the FMS library and is used elsewhere in the code, so, to avoid confusion, it seems logical for GFS_typedefs.F90 to use the FMS version too. A wrapper for the get_tracer_index was added to GFS_typedefs.F90 because the FMS version returns a large negative integer for a missing tracer, whereas the rest of the physics code expects missing tracers to have an integer value of -99.Issue(s) addressed
None
Testing
There has been significant testing of individual pieces of this work. Each PR that had been targeted to ufs/dev individually had been tested by itself using UFS RTs on supported platforms. The update to NCAR:main branch was tested together with the removal of gfdl_parse_tracers.F90 changes in GFS_typedefs using UFS RTs on Hera.
Dependencies
ufs-community/ccpp-physics#295