Skip to content

Conversation

@grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented Apr 17, 2025

Description

This PR contains many physics bugfixes and updates described in ufs-community/ccpp-physics#295. The only physics changes requiring changes to the code in fv3atm are as follows:

Issue(s) addressed

None

Testing

There has been significant testing of individual pieces of this work. Each PR that had been targeted to ufs/dev individually had been tested by itself using UFS RTs on supported platforms. The update to NCAR:main branch was tested together with the removal of gfdl_parse_tracers.F90 changes in GFS_typedefs using UFS RTs on Hera.

Dependencies

ufs-community/ccpp-physics#295

@grantfirl grantfirl changed the title Use tracer_manager_mod from FMS for GFS_typedefs Combination PR (use FMS tracer_manager for tracer parsing, ECMWF non-stationary GWD changes, other misc. physics changes) Jun 27, 2025
@grantfirl grantfirl marked this pull request as ready for review June 27, 2025 18:57
@grantfirl
Copy link
Collaborator Author

Replaces:
#952
#968

@rhaesung
Copy link
Contributor

@grantfirl ufs-community/ccpp-physics#295 has been merged. Please update the submodule pointer for ccpp-physics ( ufs-community/ccpp-physics@ef272c1) and revert the .gitmodules file in preparation for the merge.

@grantfirl
Copy link
Collaborator Author

@jkbk2004 Submodule updated and ready for review/merge

@jkbk2004 jkbk2004 self-requested a review July 11, 2025 13:46
@jkbk2004 jkbk2004 merged commit ceb0f5d into NOAA-EMC:develop Jul 11, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash in cu_c3_driver.F90 when not using mynn edmf due to access of unallocated maxMF array.

6 participants