Bug fix to maxMF check: only access when do_mynnedmf=.true. #968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
13 tasks
DusanJovic-NOAA
changed the title
Collaborator
|
@SamuelTrahanNOAA This has been combined into #950 for helping with the UFS merge queue workload. This should be left open until that is merged in case the combination PR has problems. |
Collaborator
|
Merged via #950 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug fix to ufs-community/ccpp-physics#282 to guard against accessing maxMF in
cu_c3_driver.F90when that array is not allocated.See issue for full explanation.
Issue(s) addressed
Testing
How were these changes tested?
Experimental physics suite that uses C3 but not mynn edmf crashed without these changes but ran with the changes. See issue for full description.
What compilers / HPCs was it tested with?
Hera and Hercules with the Intel compiler..
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
The experimental physics suite that triggers these bugs doesn't self-reproduce, so I cannot make a regression test for it yet. The reproducibility bug is unrelated and will be the subject of another Issue shortly.
Have the ufs-weather-model regression test been run? On what platform?
Yes. Hera.
Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
No. Either it crashes or it doesn't.
Please commit the regression test log files in your ufs-weather-model branch
Done.
Dependencies