Skip to content

Conversation

@wujingyue
Copy link
Collaborator

@wujingyue wujingyue commented Oct 6, 2025

@wujingyue
Copy link
Collaborator Author

!test

@github-actions
Copy link

github-actions bot commented Oct 6, 2025

Review updated until commit 5131437

Description

  • Replace emplace_back with push_back for clarity

  • Remove unnecessary NOLINT comment

  • Simplify contiguity vector initialization

  • Improve code readability and consistency


Changes walkthrough 📝

Relevant files
Enhancement
alias_analysis.cpp
Replace emplace_back with push_back                                           

csrc/alias_analysis.cpp

  • Use push_back instead of emplace_back
  • No functional change, improves readability
  • +1/-1     
    nodes.cpp
    Use push_back for optional vector                                   

    csrc/ir/nodes.cpp

  • Replace emplace_back with push_back
  • Maintain same logic for optional values
  • +1/-1     
    Miscellaneous
    transform_replay.cpp
    Remove unused lint disabler comment                                           

    csrc/transform_replay.cpp

  • Remove unnecessary NOLINT comment
  • Keep push_back usage consistent
  • +0/-1     

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🧪 No relevant tests
    ⚡ No major issues detected

    @wujingyue wujingyue changed the title Remove an unnecessary lint disabler push_back(std::nullopt) and remove unnecessary lint disablers Oct 7, 2025
    @wujingyue
    Copy link
    Collaborator Author

    !build

    @wujingyue wujingyue merged commit f347183 into main Oct 7, 2025
    17 checks passed
    @wujingyue wujingyue deleted the wjy/disable branch October 7, 2025 22:46
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants