Skip to content

push_back(std::nullopt) and remove unnecessary lint disablers #5329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2025
+2 −3
Merged

push_back(std::nullopt) and remove unnecessary lint disablers #5329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c4bfd9
Remove an unnecessary lint disabler
wujingyue Oct 6, 2025
5131437
More
wujingyue Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion csrc/alias_analysis.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ void AliasFinder::handle(const BroadcastOp* bcast) {
for (const auto i : arange(out_logical.size())) {
if (bcast->isBroadcastDim(i)) {
out_allocation.push_back(out_logical[i]);
out_contiguity.emplace_back(std::nullopt);
out_contiguity.push_back(std::nullopt);
}
}

Expand Down
2 changes: 1 addition & 1 deletion csrc/ir/nodes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3966,7 +3966,7 @@ std::vector<IterDomain*> TensorDomain::noDevices(
contiguity.reserve(allocation_domain.size());
for (auto id : allocation_domain) {
if (id->isBroadcast() || id->isReduction()) {
contiguity.emplace_back(std::nullopt);
contiguity.push_back(std::nullopt);
} else {
contiguity.emplace_back(fill_value);
}
Expand Down
1 change: 0 additions & 1 deletion csrc/transform_replay.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,6 @@ void TransformReplay::selfReplay(
for (auto* id : new_self->logical()) {
if (id->isReduction()) {
new_allocation.push_back(id);
// NOLINTNEXTLINE(modernize-use-emplace)
new_contiguities.push_back(std::nullopt);
}
}
Expand Down