-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix BWUtil report on early exit #1994
Conversation
I noticed this as well when I added the benchmark in #1944 and added a question for the reviewers: #1944 (review). However, both @miscco and @gevtushenko did not react to the comment and approved the PR, so I eventually dropped my worries. Maybe they missed the commend, so it's good you bring this up again! |
I would actually favor not reporting a bandwidth at all. It just highly depends on the implementation of |
|
My bad, I forgot to answer your question.
I'm not sure if tuning infrastructure and CI scripts support that.
For now, all the execution policies in Thrust read from the beginning and short circuit. We can revisit this question when we get one of the implementations that do not read from the beginning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name different_elems
confused me, because it seems to me it actually denotes the number of equal elements. If you agree, please also rename the variable, e.g. to same_elems
.
It could be that I wanted to name the variable different_elems_start
, but somehow failed to complete the name :)
Also, the variable name
at the top is no longer needed. Please also remove it. Thx!
Good point! Also, if we report no bandwidth, we cannot report a SOL%, right? |
Yes, reporting SOL% is the only reason we have BW reporting in our benches |
🟨 CI finished in 18h 17m: Pass: 99%/250 | Total: 1d 06h | Avg: 7m 25s | Max: 43m 27s | Hits: 99%/247363
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
+/- | Thrust |
CUDA Experimental | |
pycuda |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | pycuda |
🏃 Runner counts (total jobs: 250)
# | Runner |
---|---|
178 | linux-amd64-cpu16 |
41 | linux-amd64-gpu-v100-latest-1 |
16 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
b8e6dfd
to
efd7d7f
Compare
/ok to test |
🟨 CI finished in 4h 39m: Pass: 99%/250 | Total: 4d 01h | Avg: 23m 30s | Max: 44m 32s | Hits: 75%/247357
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
+/- | Thrust |
CUDA Experimental | |
pycuda |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | pycuda |
🏃 Runner counts (total jobs: 250)
# | Runner |
---|---|
178 | linux-amd64-cpu16 |
41 | linux-amd64-gpu-v100-latest-1 |
16 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
🟩 CI finished in 7h 22m: Pass: 100%/250 | Total: 4d 02h | Avg: 23m 33s | Max: 44m 32s | Hits: 75%/248210
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
+/- | Thrust |
CUDA Experimental | |
pycuda |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | pycuda |
🏃 Runner counts (total jobs: 250)
# | Runner |
---|---|
178 | linux-amd64-cpu16 |
41 | linux-amd64-gpu-v100-latest-1 |
16 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
Description
We used to read all the elements to report
BWUtil
even on early exit forthrust::equal
. That results onBWUtil
being reported to be more than 100% in cases of early exit. Random example:This fixes that.