Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BWUtil report on early exit #1994

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Fix BWUtil report on early exit #1994

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d9392e6
Fix BWUtil report on early exit
gonidelis Jul 15, 2024
efd7d7f
Resolve reviews for correctness
gonidelis Jul 16, 2024
c98dd0d
Merge branch 'main' into equal_benchmark_fix
gonidelis Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions thrust/benchmarks/bench/equal/basic.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,20 +10,22 @@
template <typename T>
static void benchmark(nvbench::state& state, nvbench::type_list<T>)
{
const auto& name = state.get_benchmark().get_name();
const auto elements = static_cast<std::size_t>(state.get_int64("Elements"));
thrust::device_vector<T> a(elements, T{1});
thrust::device_vector<T> b(elements, T{1});

const auto common_prefix = state.get_float64("CommonPrefixRatio");
const auto different_elems = std::min(static_cast<std::size_t>(elements * common_prefix), elements);
const auto common_prefix = state.get_float64("CommonPrefixRatio");
const auto same_elements = std::min(static_cast<std::size_t>(elements * common_prefix), elements);
caching_allocator_t alloc;
thrust::fill(policy(alloc), b.begin() + different_elems, b.end(), T{2});
thrust::fill(policy(alloc), b.begin() + same_elements, b.end(), T{2});

state.add_element_count(elements);
state.add_global_memory_reads<T>(2 * elements);
state.exec(nvbench::exec_tag::no_batch | nvbench::exec_tag::sync, [&](nvbench::launch&) {
do_not_optimize(thrust::equal(policy(alloc), a.begin(), a.end(), b.begin()));
state.add_global_memory_reads<T>(2 * std::max(same_elements, std::size_t(1))); // using `same_elements` instead
// of `elements` corresponds to the
// actual elements read in an early
// exit
state.exec(nvbench::exec_tag::no_batch | nvbench::exec_tag::sync, [&](nvbench::launch& launch) {
do_not_optimize(thrust::equal(policy(alloc, launch), a.begin(), a.end(), b.begin()));
});
}

Expand Down
Loading