Fix/modernize thrust examples

[Flawxd]

Following #724

Modernizes the thrust/examples/word_count.cu example by replacing the functor struct is_word_start with an extended lambda
to align with modern C++ practices and to make it easier to read

Changes:

Replaced struct is_word_start with a host device lambda.

Replaced C-style array pointer arithmetic with std::begin() and std::end() for safer iterator access.

The code was verified using a T4 GPU and ran perfectly

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[bernhardmgruber]

/ok to test e89e7c2

[bernhardmgruber]

/ok to test a104277

[bernhardmgruber]

pre-commit.ci autofix

[bernhardmgruber]

From the CI:

 /home/coder/cccl/thrust/examples/word_count.cu(31): error: __host__ or __device__ annotation on lambda requires --extended-lambda nvcc flag
      auto is_word_start = [] __attribute__((host)) __attribute__((device))(const char& left, const char& right) {
                                                                        ^

Please add a new file thrust/examples/word_count.cmake with content:

target_compile_options(
  ${example_target}
  PRIVATE $<$<COMPILE_LANG_AND_ID:CUDA,NVIDIA>: --extended-lambda>
)

[bernhardmgruber]

The code was verified using a T4 GPU and ran perfectly

@Flawxd I wonder how you verfied this, because the example in the PR cannot be compiled without --extended-lambda. Please make sure you test compiling the example with our build system!

[Flawxd]

@Flawxd I wonder how you verfied this, because the example in the PR cannot be compiled without --extended-lambda. Please make sure you test compiling the example with our build system!

Yes, I did test it using --extend-lambda, it was an oversight from me to not include it in a cmake file, I'll push the new file

[bernhardmgruber]

pre-commit.ci autofix

[bernhardmgruber]

/ok to test 3f87a1d

[bernhardmgruber]

Please also add this to the cmake file:

  # When clang >= 13 is used as host compiler, we get the following warning:
  #   nvcc_internal_extended_lambda_implementation:312:22: error: definition of implicit copy constructor for '__nv_hdl_wrapper_t<false, true, false, __nv_dl_tag<void (*)(), &TestAddressStabilityLambda, 2>, int (const int &)>' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy]
  #   312 | __nv_hdl_wrapper_t & operator=(const __nv_hdl_wrapper_t &in) = delete;
  #   |                      ^
  # Let's suppress it until NVBug 4980157 is resolved.
  target_compile_options(
    ${test_target}
    PRIVATE $<$<COMPILE_LANG_AND_ID:CUDA,NVIDIA>:-Wno-deprecated-copy>
  )

we already have this fix in other places.

[Flawxd]

Hello, isnt the correct variable example_target instead of test_target ?
Also, from what I can see the warning only appears for clang >=13 so shouldnt we test and apply only after seeing that the version is greater than 12 ? so something like

target_compile_options(
  ${example_target}
  PRIVATE $<$<COMPILE_LANG_AND_ID:CUDA,NVIDIA>: --extended-lambda>
)

if (
  "Clang" STREQUAL "${CMAKE_CXX_COMPILER_ID}"
  AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 13
)
  # When clang >= 13 is used as host compiler, we get the following warning:
  #   nvcc_internal_extended_lambda_implementation:312:22: error: definition of implicit copy constructor for '__nv_hdl_wrapper_t<false, true, false, __nv_dl_tag<void (*)(), &TestAddressStabilityLambda, 2>, int (const int &)>' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy]
  #   312 | __nv_hdl_wrapper_t & operator=(const __nv_hdl_wrapper_t &in) = delete;
  #       |                      ^
  # Let's suppress it until NVBug 4980157 is resolved.
  target_compile_options(
    ${example_target}
    PRIVATE $<$<COMPILE_LANG_AND_ID:CUDA,NVIDIA>: -Wno-deprecated-copy>
  )
endif()

[bernhardmgruber]

Hello, isnt the correct variable example_target instead of test_target

Correct. I copied this from a test.

Also, from what I can see the warning only appears for clang >=13 so shouldnt we test and apply only after seeing that the version is greater than 12 ?

Yes, but this may be trickier than it sounds. CMAKE_CXX_COMPILER_ID is CMake's C++ compiler and this could be a different compiler than the CMAKE_CUDA_HOST_COMPILER. We guard against this somewhere in CMake, but if you take the example CMake scripts out of context, they could be different. Recent versions of CMake allow better inspection of the host compiler, but then we need to handle different versions of CMake. It's just a lot easier to just disable the warning for nvcc.

[Flawxd]

Alright then, I'll do what you suggested with the correct variable

[bernhardmgruber]

/ok to test 3fd0ed9

[bernhardmgruber]

/ok to test e92d109

[bernhardmgruber]

Also, from what I can see the warning only appears for clang >=13 so shouldnt we test and apply only after seeing that the version is greater than 12 ?

Yes, but this may be trickier than it sounds. CMAKE_CXX_COMPILER_ID is CMake's C++ compiler and this could be a different compiler than the CMAKE_CUDA_HOST_COMPILER. We guard against this somewhere in CMake, but if you take the example CMake scripts out of context, they could be different. Recent versions of CMake allow better inspection of the host compiler, but then we need to handle different versions of CMake. It's just a lot easier to just disable the warning for nvcc.

It seems I confused something, since we still have not exclude the flag for MSVC. Looking into other files, I see that we do limit the flag to when the CXX compiler is clang >=13. I pushed the change. Sorry for the noise!

[Flawxd]

No problem, thank you for the heads-up !

[bernhardmgruber]

/ok to test 113bb15

[github-actions]

🥳 CI Workflow Results

🟩 Finished in 1h 18m: Pass: 100%/51 | Total: 17h 28m | Max: 1h 11m | Hits: 99%/97068

See results here.

[miscco]

Thanks a lot for improving the examples 🎉

[Flawxd]

NP, Thanks for your guidance !