-
Notifications
You must be signed in to change notification settings - Fork 321
Fix/modernize thrust examples #7094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9e07576
Modernize word_count.cu: Replace functor with __host__ __device__ lambda
e89e7c2
Modernize word_count.cu: Replace functor with __host__ __device__ lam…
c14a968
Apply suggestions from code review
Flawxd a80617f
Review suggestion for important comment
98489e4
Update thrust/examples/word_count.cu
bernhardmgruber a104277
Update thrust/examples/word_count.cu
bernhardmgruber 0185acc
[pre-commit.ci] auto code formatting
pre-commit-ci[bot] 06e50ff
Added the cmake file that was suggested for word_count
3f87a1d
[pre-commit.ci] auto code formatting
pre-commit-ci[bot] 3fd0ed9
fixed cmake with suggestion
e92d109
Merge branch 'main' into fix/modernize-thrust-examples
bernhardmgruber 113bb15
Update thrust/examples/word_count.cmake
bernhardmgruber File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| target_compile_options( | ||
| ${example_target} | ||
| PRIVATE $<$<COMPILE_LANG_AND_ID:CUDA,NVIDIA>: --extended-lambda> | ||
| ) | ||
|
|
||
| # When clang >= 13 is used as host compiler, we get the following warning: | ||
| # nvcc_internal_extended_lambda_implementation:312:22: error: definition of implicit copy constructor for '__nv_hdl_wrapper_t<false, true, false, __nv_dl_tag<void (*)(), &TestAddressStabilityLambda, 2>, int (const int &)>' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy] | ||
| # 312 | __nv_hdl_wrapper_t & operator=(const __nv_hdl_wrapper_t &in) = delete; | ||
| # | ^ | ||
| # Let's suppress it until NVBug 4980157 is resolved. | ||
| target_compile_options( | ||
| ${example_target} | ||
| PRIVATE $<$<COMPILE_LANG_AND_ID:CUDA,NVIDIA>: -Wno-deprecated-copy> | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.