-
Notifications
You must be signed in to change notification settings - Fork 319
Rename new tuning API policies and fix MSVC warning #7103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+133
−141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NaderAlAwar
approved these changes
Jan 7, 2026
miscco
approved these changes
Jan 7, 2026
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
This CI error while compiling |
Contributor
yeah @griwes stumbled on this, looks like something with nvcc eating some of the parenthesis when generating host code |
This comment has been minimized.
This comment has been minimized.
9 tasks
9e89419 to
1c1846e
Compare
7 tasks
This comment has been minimized.
This comment has been minimized.
arch policies -> policy selector Drop _policy in members reduce_arch_policy -> reduce_policy Drop and adapt some comments
1c1846e to
e6dcc83
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
🥳 CI Workflow Results🟩 Finished in 1d 03h: Pass: 100%/247 | Total: 9d 17h | Max: 5h 30m | Hits: 58%/353181See results here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This followed a small internal discussion on naming conventions.
arch policies->policy selectorDrop
_policyin membersreduce_arch_policy->reduce_policyDrop and adapt some comments
As a drive-by:
/diagnostics:caretfor MSVC to improve diagnostics