Skip to content

Conversation

@bernhardmgruber
Copy link
Contributor

@bernhardmgruber bernhardmgruber commented Jan 7, 2026

This followed a small internal discussion on naming conventions.

arch policies -> policy selector
Drop _policy in members
reduce_arch_policy -> reduce_policy
Drop and adapt some comments

As a drive-by:

@bernhardmgruber bernhardmgruber requested review from a team as code owners January 7, 2026 14:10
@github-project-automation github-project-automation bot moved this to Todo in CCCL Jan 7, 2026
@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Review in CCCL Jan 7, 2026
@bernhardmgruber bernhardmgruber enabled auto-merge (squash) January 7, 2026 15:08
@github-actions

This comment has been minimized.

@bernhardmgruber
Copy link
Contributor Author

This CI error while compiling cccl.c.parallel.test.histogram.dir/test_histogram.cpp.obj seems a bit odd:

C:\cccl\libcudacxx\include\cuda/std/__complex/roots.h(84): error C2220: the following warning is treated as an error
  C:\cccl\libcudacxx\include\cuda/std/__complex/roots.h(84): warning C4554: '<<': check operator precedence for possible error; use parentheses to clarify precedence

@miscco
Copy link
Contributor

miscco commented Jan 8, 2026

This CI error while compiling cccl.c.parallel.test.histogram.dir/test_histogram.cpp.obj seems a bit odd:

C:\cccl\libcudacxx\include\cuda/std/__complex/roots.h(84): error C2220: the following warning is treated as an error
  C:\cccl\libcudacxx\include\cuda/std/__complex/roots.h(84): warning C4554: '<<': check operator precedence for possible error; use parentheses to clarify precedence

yeah @griwes stumbled on this, looks like something with nvcc eating some of the parenthesis when generating host code

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

arch policies -> policy selector
Drop _policy in members
reduce_arch_policy -> reduce_policy
Drop and adapt some comments
@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

🥳 CI Workflow Results

🟩 Finished in 1d 03h: Pass: 100%/247 | Total: 9d 17h | Max: 5h 30m | Hits: 58%/353181

See results here.

@bernhardmgruber bernhardmgruber merged commit 61ea9e8 into NVIDIA:main Jan 11, 2026
512 of 517 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in CCCL Jan 11, 2026
@bernhardmgruber bernhardmgruber deleted the policy_renaming branch January 11, 2026 18:55
@bernhardmgruber bernhardmgruber changed the title Rename new tuning API policies Rename new tuning API policies and fix MSVC warning Jan 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants