wheels: use system 'tileiras', search site-packages for CMake targets - #8573
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Adds wheel prefix discovery and propagates KvikIO through the installed cuVS CMake target to fix cuML builds in NVIDIA/cuml#8573. Part of rapidsai/build-planning#325. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - James Lamb (https://github.com/jameslamb) - Corey J. Nolet (https://github.com/cjnolet) URL: #2565
| ) | ||
|
|
||
| # Find C++ libraries from RAPIDS wheels in site-packages. | ||
| set_property(GLOBAL PROPERTY FIND_LIBRARY_USE_LIB64_PATHS TRUE) |
There was a problem hiding this comment.
Similar things are used in other parts of RAPIDS to ensure CMake targets installed in site-packages/ can be found.
Things like this were added in NVIDIA/cuvs#2565, for example.
|
/ok to test |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughChangesBuild dependency configuration
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to No actionable merge-blocking issue remains from the finalized review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
conda Python tests are all failing like this: That'll be fixed by #861
Not sure if that's being looked into yet, I'll look into it. |
This was NVIDIA/cudf#24116, see that issue for the resolution. No changes needed in this PR, just a re-run. |
|
/merge |
Fixes #8520
Contributes to rapidsai/build-planning#324
Contributes to rapidsai/build-planning#325
tileiraslibcumlCMake to search forpip-installed libraries (to avoid e.g. rebuilding cuVS from source in pip devcontainers)How I tested this
Relied on CI. Check it out... 9 minute pip devcontainer jobs now 😎 : https://github.com/NVIDIA/cuml/actions/runs/34501697447/job/102954296927?pr=8573