-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add actions/stale gh-action #538
Conversation
Based on https://github.com/actions/stale |
3e2df1e
to
09025b1
Compare
09025b1
to
72d806e
Compare
@@ -0,0 +1,28 @@ | |||
name: Stale issues and pull requests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: What will happen with all open issues / PRs on the first invocation of this job? Will all issues / PRs with >90 days of inactivity get labelled life-cycle/stale
? Nothing will get closed, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, it will be a busy first day for this action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes to which part of the question? Yes to both? Meaning the stale label will be added to all issues older than 90 days, but NO rotten labels will be added on the initial run, right?
As far, as I understand it, an issue first gets the stale label after 90 days of inactivity. It then needs to sit with the stale label for 90 days before it is relabeled as rotten (pinging all watchers of the issue in the process). It then needs to sit with the rotten label for 90 days before it is automatically closed.
If you remove either label (regardless of which lifecycle state it’s in), the whole process starts over and you have another 270 days before the issue is closed (90 until stale label, another 90 until rotten, and another 90 until closed).
So as long as the initial run only applies the stale label, we have 180 more days until an auto close.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, here’s the rules applied by k8s, can we just configure ours the same:
kubernetes/website#34183 (comment)
So 90,30,30 instead of 90,90,90 as I said above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, also update the labels to match lifecycle/
vs life-cycle/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after seeing the action, looks like issues older than 180 days will get closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So 90,30,30 instead of 90,90,90 as I said above.
This GitHub action only has 2 stages, so it would be 90-60, is that ok? , this PR proposes 90-90
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the PR
removed the rotten label
and adjusted the closing time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
72d806e
to
eb8d375
Compare
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
eb8d375
to
cb3949d
Compare
I'll merge after release branch |
No description provided.