-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add actions/stale gh-action #538
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| name: Stale issues and pull requests | ||
|
|
||
| on: | ||
| schedule: | ||
| - cron: "21 4 * * *" | ||
|
|
||
| jobs: | ||
| stale: | ||
| permissions: | ||
| issues: write | ||
| pull-requests: write | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/stale@v8 | ||
| with: | ||
| stale-issue-message: 'This issue has become stale and will be closed automatically within 30 days if no activity is recorded.' | ||
| stale-pr-message: 'This pull request has become stale and will be closed automatically within 30 days if no activity is recorded.' | ||
| stale-issue-label: 'life-cycle/stale' | ||
| stale-pr-label: 'life-cycle/stale' | ||
ArangoGutierrez marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| days-before-stale: 90 | ||
| close-issue-message: 'This issue was automatically closed due to inactivity.' | ||
| close-pr-message: 'This pull request was automatically closed due to inactivity.' | ||
| days-before-issue-close: 30 | ||
| days-before-pr-close: 30 | ||
| remove-stale-when-updated: true | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: What will happen with all open issues / PRs on the first invocation of this job? Will all issues / PRs with >90 days of inactivity get labelled
life-cycle/stale? Nothing will get closed, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, it will be a busy first day for this action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes to which part of the question? Yes to both? Meaning the stale label will be added to all issues older than 90 days, but NO rotten labels will be added on the initial run, right?
As far, as I understand it, an issue first gets the stale label after 90 days of inactivity. It then needs to sit with the stale label for 90 days before it is relabeled as rotten (pinging all watchers of the issue in the process). It then needs to sit with the rotten label for 90 days before it is automatically closed.
If you remove either label (regardless of which lifecycle state it’s in), the whole process starts over and you have another 270 days before the issue is closed (90 until stale label, another 90 until rotten, and another 90 until closed).
So as long as the initial run only applies the stale label, we have 180 more days until an auto close.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, here’s the rules applied by k8s, can we just configure ours the same:
kubernetes/website#34183 (comment)
So 90,30,30 instead of 90,90,90 as I said above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, also update the labels to match
lifecycle/vslife-cycle/There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after seeing the action, looks like issues older than 180 days will get closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This GitHub action only has 2 stages, so it would be 90-60, is that ok? , this PR proposes 90-90
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the PR
removed the rotten label
and adjusted the closing time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@klueska @elezar @cdesiniotis