Use functional names for hook bash functions #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename hook functions to describe their actions rather than when they run. Add documentation comments for clarity. No API changes. Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
ArangoGutierrez
changed the title
elezar
reviewed
Nov 10, 2025
deployments/systemd/hooks.sh
Outdated
| # stop-services-for-mode stops all GPU-dependent services (K8s workloads | ||
| # and driver services) before applying MIG mode changes that require a | ||
| # GPU reset. | ||
| function stop-services-for-mode() { |
Member
There was a problem hiding this comment.
Instead of duplicating the stop_k8s_services and stop_k8s_pods across stop-services-for-mode and stop-services-for-config, should we invoke stop_driver_services directly as a hook from pre-apply-mode and invoke stop-services from both apply-mode and pre-apply-config?
Collaborator
Author
There was a problem hiding this comment.
Check : Refactor: move service stop orchestration to hook configuration level , added as an additional commit. If you approve, I'lll edit the PR description
Replace stop-services-for-mode and stop-services-for-config with a single stop-services function. Build the complete stop sequence in hooks-default.yaml by invoking stop-services and stop_driver_services separately. This removes Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename hook functions to describe their actions rather than when they run. Add documentation comments for clarity. No API changes.