Warn user if ORC is used with production temperature greater than 200 degrees C - #517
Open
jeffbourdier wants to merge 1 commit into
Open
Warn user if ORC is used with production temperature greater than 200 degrees C#517jeffbourdier wants to merge 1 commit into
jeffbourdier wants to merge 1 commit into
Conversation
… degrees C (issue 513)
softwareengineerprogrammer
requested changes
Sep 2, 2026
Comment on lines
+3374
to
+3375
| msg = ('ORC is being used with a production temperature greater than 200 degrees ' | ||
| 'Celsius. ORC efficiency correlations are only valid up to 200 degrees.') |
Collaborator
There was a problem hiding this comment.
Suggested rewording: "The simulated production temperature exceeds 200°C. The built-in ORC utilization efficiency correlations may not be valid above this temperature. Consider using a single or double flash plant, or providing a custom correlation via a surface plant module. For more information, see: https://natlabrockies.github.io/GEOPHIRES-X/Theoretical-Basis-for-GEOPHIRES.html#surface-plant"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is to resolve #513.
Testing & Verification
Change Checklist
Observe the following checklist items before and after merging, as applicable.
Before merging: