Skip to content

Warn user if ORC is used with production temperature greater than 200 degrees C #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffbourdier merged 3 commits into from
Sep 8, 2026
Merged

Warn user if ORC is used with production temperature greater than 200 degrees C #517

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02087d2
Warn user if ORC is used with production temperature greater than 200…
jeffbourdier Sep 1, 2026
3f6f03e
Merge branch 'main' into ORC-prod-temp-200C
jeffbourdier Sep 7, 2026
8e6aef4
reword warning as requested (issue 513)
jeffbourdier Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/geophires_x/Economics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3369,6 +3369,15 @@ def calculate_plant_costs(self, model: Model) -> None:
# all other options have power plant
# TODO migrate relevant constants/calculations below to their respective classes

def _check_temperature_for_ORC(temperature: float) -> None:
if temperature > 200.:
msg = ('The simulated production temperature exceeds 200 degrees Celsius. The built-in ORC utilization '
'efficiency correlations may not be valid above this temperature. Consider using a single or double '
'flash plant, or providing a custom correlation via a surface plant module. For more information, '
'see: https://natlabrockies.github.io/GEOPHIRES-X/Theoretical-Basis-for-GEOPHIRES.html#surface-plant')
print(f'Warning: {msg}')
model.logger.warning(msg)

if model.surfaceplant.plant_type.value == PlantType.SUB_CRITICAL_ORC:
MaxProducedTemperature = np.max(model.surfaceplant.TenteringPP.value)
if MaxProducedTemperature < 150.:
Expand All @@ -3379,6 +3388,7 @@ def calculate_plant_costs(self, model: Model) -> None:
CCAPP1 = C3 * MaxProducedTemperature ** 3 + C2 * MaxProducedTemperature ** 2 + C1 * MaxProducedTemperature + C0
else:
CCAPP1 = 2231 - 2 * (MaxProducedTemperature - 150.)
_check_temperature_for_ORC(MaxProducedTemperature)
x = np.max(model.surfaceplant.ElectricityProduced.value)
y = np.max(model.surfaceplant.ElectricityProduced.value)
if y == 0.0:
Expand All @@ -3396,6 +3406,7 @@ def calculate_plant_costs(self, model: Model) -> None:
CCAPP1 = C3 * MaxProducedTemperature ** 3 + C2 * MaxProducedTemperature ** 2 + C1 * MaxProducedTemperature + C0
else:
CCAPP1 = 2231 - 2 * (MaxProducedTemperature - 150.)
_check_temperature_for_ORC(MaxProducedTemperature)
# factor 1.1 to make supercritical 10% more expansive than subcritical
self.Cplantcorrelation = 1.1 * CCAPP1 * math.pow(
np.max(model.surfaceplant.ElectricityProduced.value) / 15., -0.06) * np.max(
Expand Down