Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce space taken by credentials, using a migration step #55

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Reduce space taken by credentials, using a migration step #55

wants to merge 4 commits into from

Conversation

sosthene-nitrokey
Copy link

For now the migration step renames the files, testing need to be done to make sure that this will not fail when only one block remains free.

@sosthene-nitrokey sosthene-nitrokey force-pushed the space-opt-migration branch 2 times, most recently from 4c6f3e8 to cfb6c85 Compare February 14, 2024 11:16
@sosthene-nitrokey sosthene-nitrokey mentioned this pull request Feb 16, 2024
Closed
@sosthene-nitrokey sosthene-nitrokey mentioned this pull request Mar 4, 2024
Closed
1 task
@sosthene-nitrokey sosthene-nitrokey force-pushed the space-opt-migration branch 2 times, most recently from b096896 to a3757fb Compare March 7, 2024 10:12
@sosthene-nitrokey sosthene-nitrokey mentioned this pull request Mar 7, 2024
Merged
@sosthene-nitrokey sosthene-nitrokey marked this pull request as draft March 7, 2024 14:50
@sosthene-nitrokey sosthene-nitrokey force-pushed the space-opt-migration branch 3 times, most recently from 7281ee4 to 5872fc8 Compare March 25, 2024 14:27
@robin-nitrokey
Copy link
Member

Rebased onto v0.1.1-nitrokey.19. The old state can be found here: https://github.com/Nitrokey/fido-authenticator/tree/space-opt-migration-old

@robin-nitrokey robin-nitrokey force-pushed the space-opt-migration branch 2 times, most recently from fd20d30 to bbc136d Compare September 27, 2024 18:38
@robin-nitrokey
Copy link
Member

Rebased onto c145a45.

@sosthene-nitrokey @robin-nitrokey
Make credential: change the path of rks to `rp_id_hash.credential_id_…
f933359 
…hash` from `rp_id_hash/credential_id_hash`

The goal is to make credential storage more efficient, by making use of littlefs's
ability to inline file contents into the directory metadata when the file is small.
@robin-nitrokey robin-nitrokey mentioned this pull request Nov 1, 2024
Merged
@robin-nitrokey
Copy link
Member

robin-nitrokey commented Nov 1, 2024 •
edited
Loading

To be checked:

  • AFAIS the credential deletion still needs to be updated. delete_rp_dir_if_empty is no longer necessary. Theoretically, we could delete the RK dir if it is empty but that’s optional.
  • next_credential still contains a check based on rp_dir. As rp_dir is now the same for all credentials, this no longer makes sense. We should probably check the filename prefix instead (and validate the credential data?).
  • There are still some TODO comments. It’s not always clear if they are still relevant or what’s the actual todo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sosthene-nitrokey @robin-nitrokey