Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.python-dbusmock: backport test fix for bluez 5.79 #359455

Merged
merged 1 commit into from
Nov 30, 2024
Merged

python3Packages.python-dbusmock: backport test fix for bluez 5.79 #359455

merged 1 commit into from
Nov 30, 2024

Conversation

alyssais
Copy link
Member

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@alyssais alyssais mentioned this pull request Nov 26, 2024
Merged
13 tasks
trofi
trofi approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@trofi trofi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed tests for me. Thank you!

@FliegendeWurst

This comment was marked as off-topic.

Sign in to view
@alyssais
Copy link
Member Author

That link seems to be for a different package?

@FliegendeWurst
Copy link
Member

Oh right. Let me look again.

@ofborg ofborg bot requested a review from callahad November 27, 2024 21:30
@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Nov 27, 2024
@alyssais alyssais merged commit c148746 into NixOS:staging Nov 30, 2024
34 checks passed
@alyssais alyssais deleted the python-dbusmock-bluez-5.79 branch November 30, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trofi trofi trofi approved these changes

@FliegendeWurst FliegendeWurst FliegendeWurst approved these changes

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

@callahad callahad Awaiting requested review from callahad

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alyssais @FliegendeWurst @trofi @wegank