zig: use setupHook attribute on zig derivation #473413
Merged
+162
−162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixpkgs-ci
bot
requested review from
RossComputerGuy,
andrewrk,
dit7ya,
genga898,
getchoo,
jcollie,
mmlb and
pluiedev
nixpkgs-ci
bot
added
10.rebuild-linux: 11-100
nixpkgs-ci
bot
added
12.approvals: 1
jmbaur
force-pushed
the
zig-setup-hook
branch
from
bb5b2d0 to
18ef953
Compare
jmbaur
force-pushed
the
zig-setup-hook
branch
from
18ef953 to
2be232b
Compare
Contributor
Author
|
Contributor
Author
|
looks like roc is failing to build on master as well |
GetPsyched
suggested changes
Dec 23, 2025
Member
|
Member
|
Bash complains about |
jmbaur
force-pushed
the
zig-setup-hook
branch
from
2be232b to
2910927
Compare
Contributor
Author
|
Contributor
Author
I got different results 🤔 |
Contributor
Author
|
@RossComputerGuy any chance you could take another look at this? I didn't seem to run into the same breakages you did. |
kirillrdy
reviewed
Jan 3, 2026
Member
kirillrdy
left a comment
kirillrdy
left a comment
There was a problem hiding this comment.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 473413
Commit: 440c93a747de74f188145f6abb2f2771d0f5f458
x86_64-linux
✅ 57 packages built:
- arocc (aroccPackages.latest)
- aroccPackages.latest-unwrapped
- aroccStdenv
- blackshades
- bork
- cargo-lambda
- cargo-zigbuild
- creek
- dt
- findup
- flow-control
- ghostty
- ghostty.man
- ghostty.shell_integration
- ghostty.terminfo
- ghostty.vim
- glsl_analyzer
- hevi
- linuxwave
- lsr
- ly
- mepo
- minizign
- ncdu
- nixpkgs-manual
- odiff
- outfieldr
- owi
- pkgsArocc.stdenv
- pkgsZig.stdenv
- poop
- river-bedload
- river-classic
- river-classic.man
- river-ultitile
- rivercarro
- roc
- superhtml
- tuatara
- waylock
- wayprompt
- zf
- zig (zig_0_15)
- zig-zlint
- zig.doc (zig_0_15.doc)
- zigStdenv
- zig_0_13
- zig_0_13.doc
- zig_0_14
- zig_0_14.doc
- zigfetch
- zigimports
- zls (zls_0_15)
- zls_0_14
- zon2nix
- zsnow
- ztags
Member
|
Contributor
Author
|
@ofborg build wayprompt |
Member
|
Huh, I still get the bash problem where it doesn't like |
Contributor
Author
|
I haven't personally ran into the build failures nor the bash issue. Ofborg doesn't seem to fail builds either (tested with just wayprompt, https://logs.ofborg.org/?attempt_id=e1f15a20-9be5-4213-b236-3e5a06287231&key=nixos%2Fnixpkgs.473413). Does it seem fair to chalk those issues up to something with your particular setup? |
Member
|
Idk, I don't use bash so bash is stock. This is the only PR I've seen this issue with. |
nixpkgs-ci
bot
added
the
2.status: merge conflict
Contributor
Author
|
Spoke offline with @RossComputerGuy, we'll go ahead with the merge here as it's likely the breakage in his review was due to using a kernel built with 64K page size, which is known to not work well on older zig releases. |
By moving the zig setup hook to the zig derivation itself, we allow for zig to splice correctly with `callPackage`, meaning that the correct zig can be pulled in during builds when zig is in `nativeBuildInputs` (for example). This change retains the `zig.hook` attribute for backward compatibility by just pointing to the zig derivation. This also removes `zig_default_flags`, since now the setup hook is not a derivation that can be overridden. Overriding the build flags can now be done by setting `dontSetZigDefaultFlags = true`.
nixpkgs-ci
bot
removed
the
2.status: merge conflict
MithicSpirit
added a commit
to MithicSpirit/ghostty
that referenced
this pull request
Jan 11, 2026
As of NixOS/nixpkgs#473413[1], `zig.hook` is no longer necessary, and optimization flags can now be included directly in `zigBuildFlags`. [1] NixOS/nixpkgs#473413
MithicSpirit
added a commit
to MithicSpirit/ghostty
that referenced
this pull request
Jan 11, 2026
As of NixOS/nixpkgs#473413[1], `zig.hook` no longer supports `zig_default_flags`, and now they can and must be provided in `zigBuildFlags` instead. [1] NixOS/nixpkgs#473413
MithicSpirit
added a commit
to MithicSpirit/ghostty
that referenced
this pull request
Jan 11, 2026
As of NixOS/nixpkgs#473413[1], `zig.hook` no longer supports `zig_default_flags`, and now they can and must be provided in `zigBuildFlags` instead. Updating also requires removing gnome-xorg since it has been removed from nixpkgs. [1] NixOS/nixpkgs#473413
MithicSpirit
added a commit
to MithicSpirit/ghostty
that referenced
this pull request
Jan 12, 2026
As of NixOS/nixpkgs#473413[1], `zig.hook` no longer supports `zig_default_flags`, and now they can and must be provided in `zigBuildFlags` instead. Updating also requires removing gnome-xorg since it has been removed from nixpkgs. [1] NixOS/nixpkgs#473413
MithicSpirit
added a commit
to MithicSpirit/ghostty
that referenced
this pull request
Jan 12, 2026
As of NixOS/nixpkgs#473413[1], `zig.hook` no longer supports `zig_default_flags`, and now they can and must be provided in `zigBuildFlags` instead. Updating also requires removing gnome-xorg since it has been removed from nixpkgs. [1] NixOS/nixpkgs#473413
|
👋 I am not so much a nix expert here, but I think this is backwards incompatible change for existing uses of zig in devShells. I think this surfaces this issue more bluntly: #270415 Since now there's not a separate I worked around this by adding |
Member
|
It is a backwards incompatible change, that's why this PR isn't being backported to a stable release. I haven't looked into that issue that much but I've definitely seen it before. I am not sure why it is happening that way. But anyone is free to look into this and submit PR's. |
Contributor
Author
|
#479423 addresses this by setting that environment variable in configurePhase |
mitchellh
added a commit
to ghostty-org/ghostty
that referenced
this pull request
Jan 12, 2026
As of NixOS/nixpkgs#473413, `zig.hook` no longer supports `zig_default_flags`, and now they can and must be provided in `zigBuildFlags` instead. Updating also requires removing gnome-xorg since it has been removed from nixpkgs. `nix flake check` succeeds on my system (x86_64-linux), with a couple deprecation warnings that I believe aren't important.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By moving the zig setup hook to the zig derivation itself, we allow for zig to splice correctly with
callPackage, meaning that the correct zig can be pulled in during builds when zig is innativeBuildInputs(for example).This change retains the
zig.hookattribute for backward compatibility by just pointing to the zig derivation. This also removeszig_default_flags, since now the setup hook is not a derivation that can be overridden. Overriding the build flags can now be done by settingdontSetZigDefaultFlags = true.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.