fix: mod list in profile detail view not using available height#166
Open
Kalbskinder wants to merge 1 commit intoNoRiskClient:v3from
Open
fix: mod list in profile detail view not using available height#166Kalbskinder wants to merge 1 commit intoNoRiskClient:v3from
Kalbskinder wants to merge 1 commit intoNoRiskClient:v3from
Conversation
Author
|
If anyone knows how to fix the remaning issue, feel free to take over this pr |
Contributor
|
@Kalbskinder thanks a lot for the pr! appreciated |
Contributor
|
I'll test soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New vs. Old
Fixed Issue ✅
The mod list in profile detail view now uses the full available height without being cut off. Previously, the mod list had a max-height of 600px, which reduced the available space for displaying mods.
Remaining Issue⚠️
Note: This is a pre-existing issue, not caused by this fix.
The right sidebar (content types) can be scrolled unnecessarily because the mod list container uses
h-fullwithout proper height constraints from parent elements. This creates a layout where:Root cause: Missing
max-heightconstraints in the parent layout containers that would prevent the mod list from growing beyond the available viewport space.