Skip to content

fix: mod list in profile detail view not using available height #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kalbskinder wants to merge 1 commit into
base: v3
Choose a base branch
from
Open

fix: mod list in profile detail view not using available height #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/profiles/ProfileDetailViewV2.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,7 +552,7 @@ export function ProfileDetailViewV2({


{/* Content Area */}
<div className="flex-1 min-h-0">
<div className="flex-1 min-h-0 h-full">
{activeMainTab === "content" && (
<div className="flex h-full">
{/* Content Display Area */}
Expand Down
2 changes: 1 addition & 1 deletion src/components/ui/GenericContentTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ export function GenericContentTab<T>({
const effectiveLoadingItemCount = showSkeletons ? loadingItemCount : 0;

return (
<div className="flex flex-col select-none pt-[7px]">
<div className="flex flex-col select-none pt-[7px] h-full">
{/* Header with search, actions etc. */}
<div className="flex items-center justify-between mb-1 gap-2">
<div className="flex items-center gap-2 flex-grow min-w-0">
Expand Down
7 changes: 1 addition & 6 deletions src/components/ui/GenericList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,18 +152,13 @@ export function GenericList<T>({
return null; // Return nothing for empty state without background
}
if (!isEmpty) {
// Always use virtualization for better performance and consistent behavior
// Calculate height based on item count - min 400px, max 600px
const calculatedHeight = Math.min(Math.max(items.length * 60, 400), 600);

return (
<div
className={`${listContainerClassName}`}
className={`${listContainerClassName} h-full`}
>
<Virtuoso
data={items}
itemContent={(index) => renderItem(items[index], index)}
style={{ height: `${calculatedHeight}px` }}
/>
</div>
);
Expand Down