Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves issue #238: remove custom_encoder option #254

Merged
merged 7 commits into from
Oct 19, 2023
Merged

Conversation

ishagokhale
Copy link
Contributor

No description provided.

@ishagokhale ishagokhale marked this pull request as draft October 17, 2023 06:38
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #254 (5cdf662) into dev (86630e3) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #254      +/-   ##
==========================================
- Coverage   89.26%   89.24%   -0.03%     
==========================================
  Files          12       12              
  Lines         904      902       -2     
==========================================
- Hits          807      805       -2     
  Misses         97       97              
Files Coverage Δ
casanovo/denovo/model.py 97.45% <100.00%> (-0.02%) ⬇️
casanovo/denovo/model_runner.py 87.50% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bittremieux bittremieux marked this pull request as ready for review October 18, 2023 16:17
@bittremieux bittremieux linked an issue Oct 18, 2023 that may be closed by this pull request
@bittremieux bittremieux merged commit 9a44630 into dev Oct 19, 2023
5 of 6 checks passed
@bittremieux bittremieux deleted the good-first-issue branch October 19, 2023 17:38
melihyilmaz added a commit that referenced this pull request Nov 2, 2023
* Remove unused custom_encoder option (#254)

* resolves issue #238: remove custom_encoder option

* fixed lint issue

* fixed lint issue

* Revert "fixed lint issue"

This reverts commit bd1366c.

* lint

* lint issue

* Consistently format changelog.

---------

Co-authored-by: Isha Gokhale <[email protected]>
Co-authored-by: Wout Bittremieux <[email protected]>

* Correctly report AA precision and recall during validation (#253)

Fixes #252.

Co-authored-by: Melih Yilmaz <[email protected]>

* Remove gradient calculation during inference  (#258)

* Remove force_grad in inference

* Upgrade required PyTorch version

* Update CHANGELOG.md

* Update CHANGELOG.md

* Fix typo in torch version

* Specify correct Pytorch version change

---------

Co-authored-by: Wout Bittremieux <[email protected]>

* Add label smoothing

* Modify config file

* Minor fix config.yaml

* Run black

* Lint casanovo.py

---------

Co-authored-by: ishagokhale <[email protected]>
Co-authored-by: Isha Gokhale <[email protected]>
Co-authored-by: Wout Bittremieux <[email protected]>
Co-authored-by: Wout Bittremieux <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove custom_encoder from the config file
2 participants