fix(tests): CI skill remote-setup assertion and related test hygiene#3684
Closed
kshitijk4poor wants to merge 1 commit intoNousResearch:mainfrom
Closed
fix(tests): CI skill remote-setup assertion and related test hygiene#3684kshitijk4poor wants to merge 1 commit intoNousResearch:mainfrom
kshitijk4poor wants to merge 1 commit intoNousResearch:mainfrom
Conversation
kshitijk4poor
force-pushed
the
fix/test-ci-skill-remote-and-hygiene
branch
2 times, most recently
from
f48ca9a to
dc7fa78
Compare
- Skill invocation: no secret capture callback so SSH remote setup note is emitted - Patch agent.skill_utils.sys for platform checks (skill_matches_platform) - Skip CLAUDE.md priority test on Darwin (case-insensitive FS) Made-with: Cursor
kshitijk4poor
force-pushed
the
fix/test-ci-skill-remote-and-hygiene
branch
from
dc7fa78 to
e7e910b
Compare
Contributor
|
Merged via #3721 — your commit was cherry-picked onto current main with authorship preserved. Good catch on the CI failure. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What failed on CI (e.g. PR #3676)
tests/agent/test_skill_commands.py::TestBuildSkillInvocationMessage::test_preserves_remaining_remote_setup_warning— the test installed a secret-capture callback that filledTENOR_API_KEY, soskill_viewclearedsetup_neededand never builtsetup_note(including the SSHremote environmentsuffix). Production behavior is correct; the fixture was contradictory.Duplicate PR check
TERMINAL_ENVin conftest for xdist flakes — orthogonal.No open PR targets this skill-invocation /
remote environmentassertion.Other fixes (local + CI consistency)
agent.skill_utils.sys(whereskill_matches_platformreadssys.platform), nottools.skills_tool.sys.test_invoke_tool_dispatches_to_handle_function_call: expecttool_call_id=Nonepassed tohandle_function_call.test_claude_md_uppercase_takes_priority:@pytest.mark.skipif(darwin)— default macOS APFS cannot representCLAUDE.mdandclaude.mdas two files (CI remains Linux and still runs the test).Verification
6731 passed, 165 skipped.