fix(tests): CI skill remote-setup assertion and related test hygiene (salvage #3684)#3721
Merged
fix(tests): CI skill remote-setup assertion and related test hygiene (salvage #3684)#3721
Conversation
- Skill invocation: no secret capture callback so SSH remote setup note is emitted - Patch agent.skill_utils.sys for platform checks (skill_matches_platform) - Skip CLAUDE.md priority test on Darwin (case-insensitive FS) Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from PR #3684 by @kshitijk4poor (authorship preserved).
Fixes a real CI failure on current main:
test_preserves_remaining_remote_setup_warningfails because the fixture's secret callback fills the env var, clearing the setup warning before it's generated.Also fixes platform mock targets (
agent.skill_utils.sysnottools.skills_tool.sys), adds macOS APFS skipif for case-insensitive test, and reorders imports.