Fix torrent deleted without confirmation #2724
Conversation
- This commit fixes an error that torrent(s) get deleted without confirmation, even if the option is checked in the options. Previously, the delete action worked as expected using the delete button in the top menu, asking for confirmation before taking actual action. However, using the "remove" option in the context menu or the `DEL` key on the keyboard would got the torrent(s) removed immediately. They were just not calling the correct remove function. - Besides the correction of delete events handler, two other things were carried out by the way, although not on the scope of the entire app but just around the functions that were adjusted in this fix. 1. Some ident related issues were picked out by the way, like mixing spaces with tabs on the same line. 2. Documentations were added to some of the JS functions, according to my own understanding of the function. They might be incorrect, but can be polished while the project grows.
|
Thanks! |
|
@jevenski Could I ask a small favour? Could you backport just the delete key fix to the |
Yes, sure thing. Just wanna confirm that we just need the correction on bringing up the confirmation dialog, without the indent and the documentation part? |
Yes, that is correct.
Could you move this to a discussion and provide your rTorrent configuration? We need to diagnose the network side of things first, to eliminate other possibilities before we can blame the web client. ruTorrent mostly displays what it's told by rTorrent. |
* Fix torrent deleted without confirmation - This commit fixes an error that torrent(s) get deleted without confirmation, even if the option is checked in the options. Previously, the delete action worked as expected using the delete button in the top menu, asking for confirmation before taking actual action. However, using the "remove" option in the context menu or the `DEL` key on the keyboard would got the torrent(s) removed immediately. They were just not calling the correct remove function. - Besides the correction of delete events handler, two other things were carried out by the way, although not on the scope of the entire app but just around the functions that were adjusted in this fix. 1. Some ident related issues were picked out by the way, like mixing spaces with tabs on the same line. 2. Documentations were added to some of the JS functions, according to my own understanding of the function. They might be incorrect, but can be polished while the project grows. * Fix typo
* Fix torrent deleted without confirmation - This commit fixes an error that torrent(s) get deleted without confirmation, even if the option is checked in the options. Previously, the delete action worked as expected using the delete button in the top menu, asking for confirmation before taking actual action. However, using the "remove" option in the context menu or the `DEL` key on the keyboard would got the torrent(s) removed immediately. They were just not calling the correct remove function. - Besides the correction of delete events handler, two other things were carried out by the way, although not on the scope of the entire app but just around the functions that were adjusted in this fix. 1. Some ident related issues were picked out by the way, like mixing spaces with tabs on the same line. 2. Documentations were added to some of the JS functions, according to my own understanding of the function. They might be incorrect, but can be polished while the project grows. * Fix typo
* Fix torrent deleted without confirmation - This commit fixes an error that torrent(s) get deleted without confirmation, even if the option is checked in the options. Previously, the delete action worked as expected using the delete button in the top menu, asking for confirmation before taking actual action. However, using the "remove" option in the context menu or the `DEL` key on the keyboard would got the torrent(s) removed immediately. They were just not calling the correct remove function. - Besides the correction of delete events handler, two other things were carried out by the way, although not on the scope of the entire app but just around the functions that were adjusted in this fix. 1. Some ident related issues were picked out by the way, like mixing spaces with tabs on the same line. 2. Documentations were added to some of the JS functions, according to my own understanding of the function. They might be incorrect, but can be polished while the project grows.
DELkey on the keyboard would got the torrent(s) removed immediately. They were just not calling the correct remove function.Related:
#2596
#2721 (comment) (the part of accidentally tapping "remove" in the last paragraph)