Assorted tweaks #205
Closed
Assorted tweaks #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
copperwater
reviewed
Oct 17, 2021
People might think it's an acronym like AC if it's all capitalized.
Note about the non-typo: older or shakespearian language used proclitic contractions, not enclitic contractions.
todo XXX: involve madLibs.c someday
By which we really mean furnaces.
The straitjacket/pigeonhole was very tight indeed, for many roles. Increase the flexibility of players to adapt to equipment drops.
...was only applying to default-case species that don't have any particular species multishot bonuses.
RojjaCebolla
force-pushed
the
smallTweaks
branch
from
8b18486
to
8f46330
Compare
We had 14 different polearms (including the lance, which uses a different skill but can "pound" at range like other polearms). Now, there's 4 that spawn normally: halberd, ranseur, lance, partisan Scythes can also be generated, but only in specific monster inventories.
RojjaCebolla
force-pushed
the
smallTweaks
branch
from
a733c47
to
08c59e4
Compare
This only applies to the T-Rex specific death message.
patch by nhmall
Centaurs still never spawn wearing a saddle, but quadrupeds, unicorns, and dragons rarely might!
(Also remove a redundant do_known)
The best way to ID wands is still to be !Blind and !Hallu, however, a few extra conditionals in here will improve things for conducts or weird moments.
copperwater
reviewed
Oct 25, 2021
| @@ -238,13 +238,20 @@ bhitm(struct monst *mtmp, struct obj *otmp) | |||
| break; | |||
| case WAN_SPEED_MONSTER: | |||
| if (!resist(mtmp, otmp->oclass, 0, NOTELL)) { | |||
| if (mtmp->data == &mons[PM_HEDGEHOG]) { | |||
| pline("Gotta go fast!"); | |||
There was a problem hiding this comment.
This should arguably be checked for being able to see or spot mtmp
| if (!mtmp->mtame) { | ||
| (void) tamedog(mtmp, (struct obj *) 0); | ||
| mtmp->movement += VERY_FAST; | ||
| if (rn2(2)) mtmp = christen_monst(mtmp, "Sanic"); |
There was a problem hiding this comment.
Sanic is... ehh... kind of too cringy of a meme to put directly in nethack, if you ask me.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should a sonic wand zap shatter/kill an ice elemental, or should it convert that into a water elemental?