Just the fixes #222
Merged
Just the fixes #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This only applies to the T-Rex specific death message.
|
I don't think any rebasing is necessary in this scenario, and rebasing should be avoided unless absolutely one hundred percent necessary. Rebasing is destructive to the history of a repository, and very dangerous. |
|
@NullCGT Ah, ok - thought it might be alright for a not-merged PR. But i'll not do that, then! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two of the fixes from #205 already got pushed to 1.0, which itself got merged into 1.1. So those two commits can be rebased out of the PR, and these two commits can be peeled out to be ready for a server version bump.
And that simplifies the ridicihuge PR a bit!