Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] partner_time_to_pay: Migration to 17.0 #330

Merged
merged 24 commits into from
Aug 7, 2024

Conversation

BernatObrador
Copy link

@BernatObrador BernatObrador commented Jul 18, 2024

Module migrated to version 17.0

cc https://github.com/APSL 158293

@miquelalzanillas @lbarry-apsl @mpascuall @peluko00 @javierobcn @ppyczko please review

max3903 and others added 23 commits July 17, 2024 12:31
- d2r fields are computed with out_invoice (account receivables)
- d2p fields are computed with in_invoice (account payables)
…iled lines

Use reconciled items to get the full reconciled date instead of payments
Duplicate declaration of d2x_ytd and d2x_life variables
Currently translated at 100.0% (16 of 16 strings)

Translation: account-invoice-reporting-16.0/account-invoice-reporting-16.0-partner_time_to_pay
Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-16-0/account-invoice-reporting-16-0-partner_time_to_pay/it/
Currently translated at 100.0% (16 of 16 strings)

Translation: account-invoice-reporting-16.0/account-invoice-reporting-16.0-partner_time_to_pay
Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-16-0/account-invoice-reporting-16-0-partner_time_to_pay/it/
@BernatObrador BernatObrador mentioned this pull request Jul 18, 2024
8 tasks
Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, checked in runboat

Copy link

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review and tested in runboat

Copy link

@ppyczko ppyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review and tested in runboat

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@BernatObrador BernatObrador force-pushed the 17.0-mig-partner_time_to_pay branch from ce9b050 to 6eb4a14 Compare August 7, 2024 06:37
@BernatObrador BernatObrador force-pushed the 17.0-mig-partner_time_to_pay branch from 6eb4a14 to eef7e35 Compare August 7, 2024 07:26
@BernatObrador
Copy link
Author

@pedrobaeza Is this ready to merge?

@pedrobaeza
Copy link
Member

/ocabot migration partner_time_to_pay

A PSC or module maintainer should confirm, as I don't use this module.

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Aug 7, 2024
@BernatObrador
Copy link
Author

@max3903 Is this ready to merge?

@max3903
Copy link
Member

max3903 commented Aug 7, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-330-by-max3903-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 924a56a into OCA:17.0 Aug 7, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d86cc47. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.