[ADD] Add partner contract anniversary date fields #1285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbejaoui
requested changes
Aug 19, 2025
| "version": "18.0.1.0.0", | ||
| "license": "AGPL-3", | ||
| "author": "ACSONE SA/NV, Odoo Community Association (OCA)", | ||
| "category": "marketing", |
There was a problem hiding this comment.
Suggested change
| "category": "marketing", | |
| "category": "contract", |
Comment on lines
11
to
18
| first_contract_line_start_date = fields.Date( | ||
| string="First Contract Date", | ||
| compute="_compute_contract_anniversary_date", | ||
| ) | ||
| contract_anniversary_date = fields.Date( | ||
| compute="_compute_contract_anniversary_date", | ||
| search="_search_contract_anniversary_date", | ||
| ) |
There was a problem hiding this comment.
I think these fields could just be stored fields updated by a cron that runs once a year. That would make the code much simpler and avoid performance issues with searches and computations on large databases.
def _cron_update_contract_anniversary(self):
def _anniv(d: date, year: int) -> date:
try:
return d.replace(year=year)
except ValueError:
return date(year, 2, 28)
partners = self.search([])
groups = self.env['contract.line'].read_group(
domain=[('is_canceled', '!=', True), ('partner_id', 'in', partners.ids)],
fields=['date_start:min', 'partner_id'],
groupby=['partner_id'],
)
first_start = {
g['partner_id'][0]: fields.Date.to_date(g['date_start'])
for g in groups if g.get('date_start')
}
this_year = fields.Date.context_today(self).year
for p in partners:
d0 = first_start.get(p.id)
anniv = _anniv(d0, this_year) if d0 else False
p.write({'first_contract_line_start_date': d0, 'contract_anniversary_date': anniv})<record id="ir_cron_update_contract_anniversary" model="ir.cron">
<field name="name">Partners: Update Contract Anniversaries</field>
<field name="model_id" ref="base.model_res_partner"/>
<field name="state">code</field>
<field name="code">model._cron_update_contract_anniversary()</field>
<field name="interval_number">12</field>
<field name="interval_type">months</field>
<field name="numbercall">-1</field>
<field name="nextcall">2026-01-01 01:30:00</field>
<field name="active">True</field>
</record>
|
@samirGuesmi Let's finalize this during OCA days 🚀 |
samirGuesmi
force-pushed
the
18.0-PartnerContractAnniversary-sgu
branch
from
8462e3f to
b2eda4d
Compare
|
Thanks for the review, here we are. |
sbejaoui
requested changes
Sep 17, 2025
| class ResPartner(models.Model): | ||
| _inherit = "res.partner" | ||
|
|
||
| first_contract_line_start_date = fields.Date(string="First Contract Date") |
There was a problem hiding this comment.
Suggested change
| first_contract_line_start_date = fields.Date(string="First Contract Date") | |
| first_contract_line_start_date = fields.Date(string="First Contract Date", readonly=True) |
| _inherit = "res.partner" | ||
|
|
||
| first_contract_line_start_date = fields.Date(string="First Contract Date") | ||
| contract_anniversary_date = fields.Date() |
There was a problem hiding this comment.
Suggested change
| contract_anniversary_date = fields.Date() | |
| contract_anniversary_date = fields.Date(readonly=True) |
|
|
||
| @tagged("post_install", "-at_install") | ||
| class TestContractPartnerAnniversary(TestContract): | ||
| def test_check_anniversary_date(self): |
There was a problem hiding this comment.
please add a test for 29/02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addon add a field for first contract line start date and compute contract anniversary date, useful for renewals and customer relationship management.