-
-
Notifications
You must be signed in to change notification settings - Fork 576
[ADD] Add partner contract anniversary date fields #1285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
samirGuesmi
wants to merge
1
commit into
OCA:18.0
Choose a base branch
from
acsone:18.0-PartnerContractAnniversary-sgu
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,115 @@ | ||
| ============================ | ||
| Partner Contract Anniversary | ||
| ============================ | ||
|
|
||
| .. | ||
| !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
| !! This file is generated by oca-gen-addon-readme !! | ||
| !! changes will be overwritten. !! | ||
| !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
| !! source digest: sha256:b636c7a029d6112ebc27c732b83cfe8121cf149cf7e7d416947b222c36012302 | ||
| !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
|
|
||
| .. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png | ||
| :target: https://odoo-community.org/page/development-status | ||
| :alt: Beta | ||
| .. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png | ||
| :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html | ||
| :alt: License: AGPL-3 | ||
| .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fcontract-lightgray.png?logo=github | ||
| :target: https://github.com/OCA/contract/tree/18.0/partner_contract_anniversary | ||
| :alt: OCA/contract | ||
| .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png | ||
| :target: https://translation.odoo-community.org/projects/contract-18-0/contract-18-0-partner_contract_anniversary | ||
| :alt: Translate me on Weblate | ||
| .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png | ||
| :target: https://runboat.odoo-community.org/builds?repo=OCA/contract&target_branch=18.0 | ||
| :alt: Try me on Runboat | ||
|
|
||
| |badge1| |badge2| |badge3| |badge4| |badge5| | ||
|
|
||
| This module adds contract anniversary tracking to partner records, | ||
| automatically calculating the first contract date and current year’s | ||
| anniversary date. It includes a dedicated Contracts tab in the partner | ||
| form and allows filtering by anniversary dates, useful for renewals and | ||
| customer relationship management. | ||
|
|
||
| **Table of contents** | ||
|
|
||
| .. contents:: | ||
| :local: | ||
|
|
||
| Usage | ||
| ===== | ||
|
|
||
| Viewing Contract Dates | ||
| ---------------------- | ||
|
|
||
| 1. Navigate to **Contacts** → **Contacts** | ||
| 2. Open any partner record | ||
| 3. Click on the **Contracts** tab to view: | ||
|
|
||
| - **First Contract Date**: The earliest contract start date | ||
| - **Contract Anniversary Date**: This year's anniversary date | ||
| (automatically calculated) | ||
|
|
||
| Searching by Anniversary Date | ||
| ----------------------------- | ||
|
|
||
| 1. Go to **Contacts** → **Contacts** | ||
| 2. Click the **Filters** button | ||
| 3. Select **Advanced Search** | ||
| 4. Use the **Contract Anniversary Date** field to: | ||
|
|
||
| - Find contacts with anniversaries on specific dates | ||
| - Filter for upcoming anniversaries | ||
| - Identify contacts without contracts | ||
|
|
||
| Bug Tracker | ||
| =========== | ||
|
|
||
| Bugs are tracked on `GitHub Issues <https://github.com/OCA/contract/issues>`_. | ||
| In case of trouble, please check there if your issue has already been reported. | ||
| If you spotted it first, help us to smash it by providing a detailed and welcomed | ||
| `feedback <https://github.com/OCA/contract/issues/new?body=module:%20partner_contract_anniversary%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_. | ||
|
|
||
| Do not contact contributors directly about support or help with technical issues. | ||
|
|
||
| Credits | ||
| ======= | ||
|
|
||
| Authors | ||
| ------- | ||
|
|
||
| * ACSONE SA/NV | ||
|
|
||
| Contributors | ||
| ------------ | ||
|
|
||
| - Souheil BEJAOUI <[email protected]> | ||
| - Samir GUESMI <[email protected]> | ||
|
|
||
| Maintainers | ||
| ----------- | ||
|
|
||
| This module is maintained by the OCA. | ||
|
|
||
| .. image:: https://odoo-community.org/logo.png | ||
| :alt: Odoo Community Association | ||
| :target: https://odoo-community.org | ||
|
|
||
| OCA, or the Odoo Community Association, is a nonprofit organization whose | ||
| mission is to support the collaborative development of Odoo features and | ||
| promote its widespread use. | ||
|
|
||
| .. |maintainer-sbejaoui| image:: https://github.com/sbejaoui.png?size=40px | ||
| :target: https://github.com/sbejaoui | ||
| :alt: sbejaoui | ||
|
|
||
| Current `maintainer <https://odoo-community.org/page/maintainer-role>`__: | ||
|
|
||
| |maintainer-sbejaoui| | ||
|
|
||
| This module is part of the `OCA/contract <https://github.com/OCA/contract/tree/18.0/partner_contract_anniversary>`_ project on GitHub. | ||
|
|
||
| You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| from . import models |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| # Copyright 2019 ACSONE SA/NV | ||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
|
|
||
| { | ||
| "name": "Partner Contract Anniversary", | ||
| "summary": """ | ||
| This addon add a field for first contract line start date and compute | ||
| contract anniversary date""", | ||
| "version": "18.0.1.0.0", | ||
| "license": "AGPL-3", | ||
| "author": "ACSONE SA/NV, Odoo Community Association (OCA)", | ||
| "category": "marketing", | ||
| "website": "https://github.com/OCA/contract", | ||
| "depends": [ | ||
| # OCA | ||
| "contract", | ||
| ], | ||
| "external_dependencies": { | ||
| "python": ["psycopg2"], | ||
| }, | ||
| "data": [ | ||
| "views/res_partner.xml", | ||
| "data/cron.xml", | ||
| ], | ||
| "maintainers": ["sbejaoui"], | ||
| "installable": True, | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| <?xml version="1.0" encoding="utf-8" ?> | ||
| <!-- Copyright 2025 ACSONE SA/NV | ||
| License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). --> | ||
| <odoo> | ||
| <record id="ir_cron_update_contract_anniversary" model="ir.cron"> | ||
| <field name="name">Partners: Update Contract Anniversaries</field> | ||
| <field name="model_id" ref="base.model_res_partner" /> | ||
| <field name="state">code</field> | ||
| <field name="code">model._cron_update_contract_anniversary()</field> | ||
| <field name="interval_number">12</field> | ||
| <field name="interval_type">months</field> | ||
| </record> | ||
| </odoo> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| from . import res_partner | ||
| from . import contract_line |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # Copyright 2025 ACSONE SA/NV | ||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
|
|
||
| from odoo import api, models | ||
|
|
||
|
|
||
| class ContractContract(models.Model): | ||
| _inherit = "contract.line" | ||
|
|
||
| @api.model_create_multi | ||
| def create(self, vals_list): | ||
| records = super().create(vals_list) | ||
| # Update contract anniversary | ||
| self.env["res.partner"]._update_contract_anniversary(records.partner_id.ids) | ||
| return records | ||
|
|
||
| def write(self, values): | ||
| res = super().write(values) | ||
| # Update contract anniversary | ||
| if "start_date" in values: | ||
| self.env["res.partner"]._update_contract_anniversary(self.partner_id.ids) | ||
| return res |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,47 @@ | ||||||
| # Copyright 2019 ACSONE SA/NV | ||||||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||||||
|
|
||||||
| from datetime import date | ||||||
|
|
||||||
| from odoo import fields, models | ||||||
|
|
||||||
|
|
||||||
| class ResPartner(models.Model): | ||||||
| _inherit = "res.partner" | ||||||
|
|
||||||
| first_contract_line_start_date = fields.Date(string="First Contract Date") | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| contract_anniversary_date = fields.Date() | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
||||||
| def _update_contract_anniversary(self, partner_ids=None): | ||||||
| def _anniv(d: date, year: int) -> date: | ||||||
| try: | ||||||
| return d.replace(year=year) | ||||||
| except ValueError: | ||||||
| return date(year, 2, 28) | ||||||
|
|
||||||
| domain = [("is_canceled", "!=", True)] | ||||||
| if partner_ids: | ||||||
| domain.append(("partner_id", "in", partner_ids)) | ||||||
| groups = self.env["contract.line"].read_group( | ||||||
| domain=[("is_canceled", "!=", True)], | ||||||
| fields=["date_start:min", "partner_id"], | ||||||
| groupby=["partner_id"], | ||||||
| ) | ||||||
| first_start = { | ||||||
| g["partner_id"][0]: fields.Date.to_date(g["date_start"]) | ||||||
| for g in groups | ||||||
| if g.get("date_start") | ||||||
| } | ||||||
| this_year = fields.Date.context_today(self).year | ||||||
| for p in self.env["res.partner"].browse(partner_ids): | ||||||
| d0 = first_start.get(p.id) | ||||||
| anniv = _anniv(d0, this_year) if d0 else False | ||||||
| p.write( | ||||||
| { | ||||||
| "first_contract_line_start_date": d0, | ||||||
| "contract_anniversary_date": anniv, | ||||||
| } | ||||||
| ) | ||||||
|
|
||||||
| def _cron_update_contract_anniversary(self): | ||||||
| self._update_contract_anniversary() | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| [build-system] | ||
| requires = ["whool"] | ||
| build-backend = "whool.buildapi" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| - Souheil BEJAOUI \<<[email protected]>\> | ||
| - Samir GUESMI \<<[email protected]>\> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| This module adds contract anniversary tracking to partner records, automatically calculating the first contract date and current year’s anniversary date. | ||
| It includes a dedicated Contracts tab in the partner form and allows filtering by anniversary dates, useful for renewals and customer relationship management. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| ## Viewing Contract Dates | ||
|
|
||
| 1. Navigate to **Contacts** → **Contacts** | ||
| 2. Open any partner record | ||
| 3. Click on the **Contracts** tab to view: | ||
| - **First Contract Date**: The earliest contract start date | ||
| - **Contract Anniversary Date**: This year's anniversary date (automatically calculated) | ||
|
|
||
| ## Searching by Anniversary Date | ||
|
|
||
| 1. Go to **Contacts** → **Contacts** | ||
| 2. Click the **Filters** button | ||
| 3. Select **Advanced Search** | ||
| 4. Use the **Contract Anniversary Date** field to: | ||
| - Find contacts with anniversaries on specific dates | ||
| - Filter for upcoming anniversaries | ||
| - Identify contacts without contracts |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.